virtual dtors

hxsam · Mar 19, 2019 · def1615 · def1615
1 parent b0e5c76
commit def1615
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 2 deletions.
diff --git a/include/taichi/common/interface.h b/include/taichi/common/interface.h
@@ -73,6 +73,9 @@ class Unit {
     TC_NOT_IMPLEMENTED;
     return "";
   }
+
+  virtual ~Unit() {
+  }
 };
 
 #define TC_IMPLEMENTATION_HOLDER_NAME(T) ImplementationHolder_##T

diff --git a/include/taichi/common/task.h b/include/taichi/common/task.h
@@ -17,9 +17,13 @@ class Task : public Unit {
     assert_info(parameters.size() == 0, "No parameters supported.");
     return this->run();
   }
+
   virtual std::string run() {
     return this->run(std::vector<std::string>());
   }
+
+  ~Task() {
+  }
 };
 
 TC_INTERFACE(Task)
@@ -65,7 +69,7 @@ task_invoke(const T &func, const std::vector<std::string> &params) {
 #define TC_REGISTER_TASK(task)                                             \
   class Task_##task : public taichi::Task {                                \
     std::string run(const std::vector<std::string> &parameters) override { \
-      return taichi::task_invoke<decltype(task)>(task, parameters);                \
+      return taichi::task_invoke<decltype(task)>(task, parameters);        \
     }                                                                      \
   };                                                                       \
   TC_IMPLEMENTATION(Task, Task_##task, #task)

diff --git a/include/taichi/dynamics/fluid2d/fluid.h b/include/taichi/dynamics/fluid2d/fluid.h
@@ -94,6 +94,9 @@ class Fluid {
     return Array<real>(Vector2i(0, 0));
   }
 
+  virtual ~Fluid() {
+  }
+
  protected:
   std::vector<Particle> particles;
 };

diff --git a/include/taichi/visual/gui.h b/include/taichi/visual/gui.h
@@ -356,7 +356,7 @@ class Canvas {
             Vector4 color) {
     position = transform(position);
 #if defined(TC_AMALGAMATED)
-    auto ttf_path = std::string(""); // use amalgamated font
+    auto ttf_path = std::string("");  // use amalgamated font
 #else
     char *root_dir = std::getenv("TAICHI_REPO_DIR");
     TC_ASSERT(root_dir != nullptr);
@@ -497,6 +497,9 @@ class GUI : public GUIBase {
     void set_hover(bool val) {
       hover = val;
     }
+
+    virtual ~Widget() {
+    }
   };
 
   std::vector<std::unique_ptr<Widget>> widgets;

diff --git a/include/taichi/visualization/particle_visualization.h b/include/taichi/visualization/particle_visualization.h
@@ -42,6 +42,8 @@ class ParticleRenderer {
   virtual void render(Array2D<Vector3> &buffer,
                       const std::vector<RenderParticle> &particles) const {
   }
+
+  virtual ~ParticleRenderer() {};
 };
 
 std::shared_ptr<Texture> rasterize_render_particles(