Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR will cover the issue #813
Adds in detail
Notes for NTC scaling
Notes for the PCF8591 chip and the driver
The IC PCF8591 only supports 100 kHz (basic 100 kbit/s mode), see section 14.4 Dynamic characteristics at page 20 of NXP specification. Running the PCF8591 in 400 kbit fast mode, which seems to be the default of most platforms now, leads to some instability (tested with 5 devices at ~370 kbit/s on tinkerboard):
strategies to overcome problems with 400 kbit:
for 1.: do "full double reading" (write control register and read, done in most other drivers) fix the problem for 3 tested devices, ~95% good calls
for 3,4.: multiple write don't stabilize this enough (only reduce to ~75%), multiple reading to an buffer and after some relaxation a single read is quite sufficient to reduce it to 5% wrong reads (for one device the problem is gone completely)
for 2.: for long conversion time, write also don't do anything for stabilization, it will be covered by the strategy above
driver:
Notes for YL-40 module driver
Because the supply voltage of i2c bus on tinkerboard seems to be 3.3V and both LED's are shining very bright, I would suggest to not run this board with 5V. Therefor some scaler are prepared for 3.3V as default. This can be changed by a with-function to each scaler function you want.