Fix: avoid double percent-encode for url scheme, iina#4861 (iina#4860)

* fix: avoid double percent-encode for url scheme

Remove manual percent-encoding for URL opened in URL scheme. This will
make URLs with special characters no longer be encoded twice and thus
openable.

See: https://developer.apple.com/documentation/foundation/url/3126806-init

* fix: make URL parsing backward compatible with older macos

Co-authored-by: low-batt <[email protected]>

iina/PlayerCore.swift

@@ -360,8 +360,26 @@ class PlayerCore: NSObject {
     if str.first == "/" {
       openURL(URL(fileURLWithPath: str))
     } else {
-      guard let pstr = str.addingPercentEncoding(withAllowedCharacters: .urlAllowed), let url = URL(string: pstr) else {
-        Logger.log("Cannot add percent encoding for \(str)", level: .error, subsystem: subsystem)
+      // For apps built with Xcode 15 or later the behavior of the URL initializer has changed when
+      // running under macOS Sonoma or later. The behavior now matches URLComponents and will
+      // automatically percent encode characters. Must not apply percent encoding to the string
+      // passed to the URL initializer if the new new behavior is active.
+      var performPercentEncoding = true
+#if compiler(>=5.9)
+      if #available(macOS 14, *) {
+        performPercentEncoding = false
+      }
+#endif
+      var pstr = str
+      if performPercentEncoding {
+        guard let encoded = str.addingPercentEncoding(withAllowedCharacters: .urlAllowed) else {
+          print("Cannot add percent encoding for \(str)")
+          return
+        }
+        pstr = encoded
+      }
+      guard let url = URL(string: pstr) else {
+        Logger.log("Cannot parse url for \(pstr)", level: .error, subsystem: subsystem)
         return
       }
       openURL(url)