Def here is an Instruction, so !isa<Instruction>(Def) is always false,

as Eli noticed. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@154641 91177308-0d34-0410-b5e6-96231b3b80d8
hylsd · Apr 13, 2012 · 0120f79 · 0120f79
1 parent 558ece2
commit 0120f79
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/lib/VMCore/Dominators.cpp b/lib/VMCore/Dominators.cpp
@@ -189,10 +189,9 @@ bool DominatorTree::dominates(const Instruction *Def,
                               const Use &U) const {
   Instruction *UserInst = dyn_cast<Instruction>(U.getUser());
 
-  // All non-instructions conceptually dominate everything. Instructions do
-  // not dominate non-instructions.
+  // Instructions do not dominate non-instructions.
   if (!UserInst)
-    return !isa<Instruction>(Def);
+    return false;
 
   const BasicBlock *DefBB = Def->getParent();