Skip to content

Commit

Permalink
Switch the TableGen record's string-based DenseMap key to use the new
Browse files Browse the repository at this point in the history
hashing infrastructure. I wonder why we don't just use StringMap here,
and I may revisit the issue if I have time, but for now I'm just trying
to consolidate.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@152023 91177308-0d34-0410-b5e6-96231b3b80d8
  • Loading branch information
chandlerc committed Mar 5, 2012
1 parent 179bc7c commit c78bd9b
Showing 1 changed file with 11 additions and 5 deletions.
16 changes: 11 additions & 5 deletions lib/TableGen/Record.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
#include "llvm/Support/Format.h"
#include "llvm/ADT/DenseMap.h"
#include "llvm/ADT/FoldingSet.h"
#include "llvm/ADT/Hashing.h"
#include "llvm/ADT/SmallVector.h"
#include "llvm/ADT/STLExtras.h"
#include "llvm/ADT/StringExtras.h"
Expand All @@ -29,6 +30,8 @@ using namespace llvm;
// std::string wrapper for DenseMap purposes
//===----------------------------------------------------------------------===//

namespace llvm {

/// TableGenStringKey - This is a wrapper for std::string suitable for
/// using as a key to a DenseMap. Because there isn't a particularly
/// good way to indicate tombstone or empty keys for strings, we want
Expand All @@ -43,14 +46,16 @@ class TableGenStringKey {
TableGenStringKey(const char *str) : data(str) {}

const std::string &str() const { return data; }


friend hash_code hash_value(const TableGenStringKey &Value) {
using llvm::hash_value;
return hash_value(Value.str());
}
private:
std::string data;
};

/// Specialize DenseMapInfo for TableGenStringKey.
namespace llvm {

template<> struct DenseMapInfo<TableGenStringKey> {
static inline TableGenStringKey getEmptyKey() {
TableGenStringKey Empty("<<<EMPTY KEY>>>");
Expand All @@ -61,15 +66,16 @@ template<> struct DenseMapInfo<TableGenStringKey> {
return Tombstone;
}
static unsigned getHashValue(const TableGenStringKey& Val) {
return HashString(Val.str());
using llvm::hash_value;
return hash_value(Val);
}
static bool isEqual(const TableGenStringKey& LHS,
const TableGenStringKey& RHS) {
return LHS.str() == RHS.str();
}
};

}
} // namespace llvm

//===----------------------------------------------------------------------===//
// Type implementations
Expand Down

0 comments on commit c78bd9b

Please sign in to comment.