Skip to content

Commit

Permalink
Fixed bug when tests in executable partially used absolute paths.
Browse files Browse the repository at this point in the history
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@182910 91177308-0d34-0410-b5e6-96231b3b80d8
  • Loading branch information
gkistanova committed May 30, 2013
1 parent e97b102 commit d5ae2c3
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions utils/lit/lit/TestFormats.py
Original file line number Diff line number Diff line change
Expand Up @@ -54,16 +54,17 @@ def getGTestTests(self, path, litConfig, localConfig):
else:
yield ''.join(nested_tests) + ln

# Note: path_in_suite should not include the executable name.
def getTestsInExecutable(self, testSuite, path_in_suite, execpath,
litConfig, localConfig):
if not execpath.endswith(self.test_suffix):
return
(dirname, basename) = os.path.split(execpath)
# Discover the tests in this executable.
for testname in self.getGTestTests(execpath, litConfig, localConfig):
testPath = path_in_suite + (dirname, basename, testname)
testPath = path_in_suite + (basename, testname)
yield Test.Test(testSuite, testPath, localConfig)

def getTestsInDirectory(self, testSuite, path_in_suite,
litConfig, localConfig):
source_path = testSuite.getSourcePath(path_in_suite)
Expand All @@ -73,10 +74,11 @@ def getTestsInDirectory(self, testSuite, path_in_suite,
# Iterate over executables in a directory.
if not os.path.normcase(filename) in self.test_sub_dir:
continue
dirpath_in_suite = path_in_suite + (filename, )
for subfilename in os.listdir(filepath):
execpath = os.path.join(filepath, subfilename)
for test in self.getTestsInExecutable(
testSuite, path_in_suite, execpath,
testSuite, dirpath_in_suite, execpath,
litConfig, localConfig):
yield test
elif ('.' in self.test_sub_dir):
Expand Down

0 comments on commit d5ae2c3

Please sign in to comment.