MDL-21695 Migrating the usage of root help files so far re-worded

AMOS BEGIN
 HLP forcepasswordchange.html,[forcepasswordchange_help,core]
 HLP interestslist.html,[interestslist_help,core]
 HLP newpassword.html,[newpassword_help,core]
 HLP permissions.html,[permissions_help,core_role]
 HLP picture.html,[newpicture_help,core]
 HLP picture.html,[newpicture_help,core_group]
 HLP roles.html,[roles_help,core_role]
AMOS END

admin/roles/lib.php

@@ -484,7 +484,7 @@ public function display() {
     protected function add_header_cells() {
         global $OUTPUT;
         echo '<th colspan="' . count($this->displaypermissions) . '" scope="col">' .
-                get_string('permission', 'role') . ' ' . $OUTPUT->old_help_icon('permissions', get_string('permissions', 'role')) . '</th>';
+                get_string('permission', 'role') . ' ' . $OUTPUT->help_icon('permissions', 'role') . '</th>';
         echo '<th class="risk" colspan="' . count($this->allrisks) . '" scope="col">' . get_string('risks','role') . '</th>';
     }
 

admin/roles/manage.php

@@ -194,7 +194,7 @@
     $table->wrap = array('nowrap', '', 'nowrap','nowrap');
     $table->width = '90%';
     $table->head = array(
-        get_string('role') . ' ' . $OUTPUT->old_help_icon('roles', get_string('roles')),
+        get_string('role') . ' ' . $OUTPUT->help_icon('roles', 'roles'),
         get_string('description'),
         get_string('shortname'),
         get_string('edit')

admin/uploaduser_form.php

@@ -216,7 +216,7 @@ function definition (){
         $editoroptions = array('maxfiles'=>0, 'maxbytes'=>0, 'trusttext'=>false, 'forcehttps'=>false);
         $mform->addElement('editor', 'description', get_string('userdescription'), null, $editoroptions);
         $mform->setType('description', PARAM_CLEANHTML);
-        $mform->setHelpButton('description', array('text2', get_string('helptext')));
+        $mform->addHelpButton('description', 'userdescription');
         $mform->setAdvanced('description');
 
         $mform->addElement('text', 'url', get_string('webpage'), 'maxlength="255" size="50"');

admin/user/user_message_form.php

@@ -11,7 +11,6 @@ function definition() {
 
         $mform->addElement('editor', 'messagebody', get_string('messagebody'), null, null);
         $mform->addRule('messagebody', '', 'required', null, 'server');
-        $mform->setHelpButton('messagebody', array('writing', 'reading', 'questions', 'richtext2'), false, 'editorhelpbutton');        
 
         $this->add_action_buttons();
     }

course/editcategory_form.php

@@ -35,7 +35,6 @@ function definition() {
             }
             $mform->addElement('select', 'theme', get_string('forcetheme'), $themes);
         }
-        $mform->setHelpButton('description_editor', array('writing', 'richtext2'), false, 'editorhelpbutton');
 
         $mform->addElement('hidden', 'id', 0);
         $mform->setType('id', PARAM_INT);

group/group_form.php

@@ -40,7 +40,7 @@ function definition () {
             $mform->addElement('select', 'hidepicture', get_string('hidepicture'), $options);
 
             $mform->addElement('file', 'imagefile', get_string('newpicture', 'group'));
-            $mform->setHelpButton('imagefile', array ('picture', get_string('helppicture')), true);
+            $mform->addHelpButton('imagefile', 'newpicture', 'group');
         }
 
         $mform->addElement('hidden','id');

lang/en/group.php

@@ -119,6 +119,7 @@
 $string['namingschemehelp'] = 'Use @ character to represent the group letter (A-Z) or # to represent the group number.';
 $string['newgrouping'] = 'New grouping';
 $string['newpicture'] = 'New picture';
+$string['newpicture_help'] = 'Select an image in JPG or PNG format. The image will be cropped to a square and resized to 100x100 pixels.';
 $string['noallocation'] = 'No allocation';
 $string['nogroups'] = 'There are no groups setup in this course yet';
 $string['nogroupsassigned'] = 'No groups assigned';