Merge branch 'MDL-76490' of https://github.com/paulholden/moodle

hyokwang-ahn · Dec 6, 2022 · e641428 · e641428
2 parents aaa2090 + 23930c2
commit e641428
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 5 deletions.
diff --git a/course/tests/behat/rename_roles.feature b/course/tests/behat/rename_roles.feature
@@ -35,9 +35,8 @@ Feature: Rename roles within a course
     And I should see "Learner (Student)" in the ".form-autocomplete-suggestions" "css_element"
     And I press the escape key
     And I set the field "Type or select..." in the "Filter 1" "fieldset" to "Tutor (Non-editing teacher)"
-
     And I click on "Student 1's role assignments" "link"
-    And I click on ".form-autocomplete-downarrow" "css_element" in the "Student 1" "table_row"
+    And I open the autocomplete suggestions list in the "Student 1" "table_row"
     And "Tutor (Non-editing teacher)" "autocomplete_suggestions" should exist
     And I click on "Cancel" "link"
     And I press "Enrol users"

diff --git a/enrol/tests/behat/add_to_group.feature b/enrol/tests/behat/add_to_group.feature
@@ -28,9 +28,8 @@ Feature: Users can be added to multiple groups at once
     And I am on "Course 1" course homepage
     And I follow "Participants"
     And I click on "Edit groups for \"Student 1\"" "link" in the "student1" "table_row"
-    And I click on ".form-autocomplete-downarrow" "css_element" in the "student1" "table_row"
+    And I open the autocomplete suggestions list in the "student1" "table_row"
     And I click on "Group 1" item in the autocomplete list
-    And I click on ".form-autocomplete-downarrow" "css_element" in the "student1" "table_row"
     And I click on "Group 2" item in the autocomplete list
     And I press the escape key
     And I click on "Save changes" "link" in the "student1" "table_row"

diff --git a/lib/tests/behat/behat_forms.php b/lib/tests/behat/behat_forms.php
@@ -722,7 +722,7 @@ public function i_click_on_item_in_the_autocomplete_list($item) {
     public function i_open_the_autocomplete_suggestions_list($container = null, $containertype = null) {
         $csstarget = ".form-autocomplete-downarrow";
         if ($container && $containertype) {
-            $this->execute('behat_general::i_click_on', [$csstarget, 'css_element', $container, $containertype]);
+            $this->execute('behat_general::i_click_on_in_the', [$csstarget, 'css_element', $container, $containertype]);
         } else {
             $this->execute('behat_general::i_click_on', [$csstarget, 'css_element']);
         }