forked from moodle/moodle
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Portfolio plugins explicitly requires parent library with superclass …
…definition I have discovered a bug with GoogleDocs portfolio in events. An event handler was defined in googledocs/lib.php and so the cron included just this library. But the inclusion failed because the superclass portfolio_plugin_push_base was not known to cron. IMHO it is generally good habit to require_once the file which defines the parent classes.
- Loading branch information
Showing
4 changed files
with
4 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,6 +5,7 @@ | |
* @author Dan Poltawski <[email protected]> | ||
* @license http://www.gnu.org/copyleft/gpl.html GNU Public License | ||
*/ | ||
require_once($CFG->libdir.'/portfolio/plugin.php'); | ||
require_once($CFG->libdir.'/googleapi.php'); | ||
|
||
class portfolio_plugin_googledocs extends portfolio_plugin_push_base { | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,7 +5,7 @@ | |
* @author Dan Poltawski <[email protected]> | ||
* @license http://www.gnu.org/copyleft/gpl.html GNU Public License | ||
*/ | ||
|
||
require_once($CFG->libdir.'/portfolio/plugin.php'); | ||
require_once($CFG->libdir.'/googleapi.php'); | ||
|
||
class portfolio_plugin_picasa extends portfolio_plugin_push_base { | ||
|