This repository has been archived by the owner on Apr 17, 2019. It is now read-only.
Fix Ansible deployment scripts #2099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- change how Docker network is created. Split down a step into two: depending on whether `overlay_network` variable is set to `true` or `false`. Also add network removal step as it might have interfered with different `overlay_network` modes. - fix docker-compose.yml template not using network name variable but hardcoded value instead Signed-off-by: Artyom Bakhtin <[email protected]>
BulatSaif
approved these changes
Feb 15, 2019
neewy
approved these changes
Feb 20, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Artyom Bakhtin [email protected]
Description of the Change
overlay_networkvariable is set totrueorfalse. Also add network removal step as it might have interfered with differentoverlay_networkmodes.Benefits
less buggy deployment scripts
Possible Drawbacks
None