Skip to content
This repository has been archived by the owner on Apr 17, 2019. It is now read-only.

Update README.md #2100

Closed
wants to merge 1 commit into from
Closed

Update README.md #2100

wants to merge 1 commit into from

Conversation

LiraLemur
Copy link
Contributor

Signed-off-by: Sara [email protected]

Description of the Change

Deleted unused badge, checked and fixed some links, changed the description. Added "Want to contribute?" section.

Benefits

At the very least, links are up-to date

Possible Drawbacks

None

Signed-off-by: Sara <[email protected]>
@LiraLemur LiraLemur requested a review from neewy February 14, 2019 14:07
@neewy neewy requested a review from igor-egorov February 17, 2019 10:53
Copy link
Contributor

@igor-egorov igor-egorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please apply minor fixes.

[![Build Status](https://jenkins.soramitsu.co.jp/buildStatus/icon?job=iroha/iroha-hyperledger/master)](https://jenkins.soramitsu.co.jp/job/iroha/job/iroha-hyperledger/job/master/)
[![Throughput Graph](https://graphs.waffle.io/hyperledger/iroha/throughput.svg)](https://waffle.io/hyperledger/iroha/metrics/throughput)

Blockchain platform Hyperledger Iroha is designed for simple creation and management of assets. This is a distributed ledger of transactions.
Iroha is a straightforward DLT, inspired by Japanese Kaizen principle — eliminate excessiveness (muri). Iroha has essential functionality for your asset, information and identity management needs, at the same time being an efficient and trustworthy byzantine fault-tolerant tool for your enterprise needs.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please start each new sentence from a new line.
Otherwise, it is difficult to comment.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DLT acronym has to be explained at least once. Please type it somewhere. For example, it can be placed in parenthesis right after the acronym.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is muri one of Japanese Kaizen principles? What is muri?

Copy link
Contributor Author

@LiraLemur LiraLemur Feb 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neewy please help me out with muri :)
Fixed other things. Please check if it's ok


<img height="300px" src="docs/image_assets/Iroha_3_sm.png"
alt="Iroha logo" title="Iroha" align="right" />

Iroha has the following features:
1. Creation and management of custom complex assets, such as currencies or indivisible rights, serial numbers, patents, etc.
1. Creation and management of custom assets, such as currencies or indivisible rights, serial numbers, patents, etc.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. Creation and management of custom assets, such as currencies or indivisible rights, serial numbers, patents, etc.
1. Creation and management of custom fungible assets, such as currencies, kilos of gold, etc.

We don't have the support of non-fungible tokes like indivisible rights, serial numbers, patents.

If you refer to SetAccountDetail, then it does not have compare-and-swap access mechanism, thus it cannot be considered as a way to implement the support for indivisible rights, serial numbers, patents.


### Are there any example applications?

[Android point app](https://github.com/hyperledger/iroha-android/tree/master/iroha-android-sample) and [JavaScript wallet](https://github.com/soramitsu/iroha-wallet-js).

### Want to help us develop Iroha?
That's great! Check out [this document](https://github.com/hyperledger/iroha/blob/master/CONTRIBUTING.md)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an empty line between the header and the paragraph.

* Submit issues via GitHub Iroha repository
* Join [Hyperledger RocketChat](https://chat.hyperledger.org) #iroha channel to discuss your concerns and proposals
* Use mailing list to spread your word within Iroha development community [[email protected]](mailto:[email protected])
* Join [Telegram chat](https://t.me/hyperledgeriroha) or [Hyperledger RocketChat](https://chat.hyperledger.org/channel/iroha) where the maintainers, contributors and fellow users are ready to help you. You can also discuss your concerns and proposals and simply chat about Iroha there or in Gitter [![Join the chat at https://gitter.im/hyperledger-iroha/Lobby](https://badges.gitter.im/hyperledger-iroha/Lobby.svg)](https://gitter.im/hyperledger-iroha/Lobby)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several sentences on the same line :(
Please split them.

@LiraLemur LiraLemur mentioned this pull request Feb 19, 2019
@LiraLemur
Copy link
Contributor Author

Closing this one because a protected branch was created and it seems impossible to push new commits into it. Please see hyperledger-iroha/iroha#2114

@LiraLemur LiraLemur closed this Feb 19, 2019
@tijohnson tijohnson deleted the LiraLemur-patch-2 branch March 21, 2019 20:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants