This repository has been archived by the owner on Apr 17, 2019. It is now read-only.
MstState: iteration methods for batches & txs #2203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mikhail Boldyrev <[email protected]>
MBoldyrev
added
needs-review
igor-egorov
reviewed
Apr 1, 2019
| } | ||
|
|
||
| void MstState::iterateTransactions( | ||
| std::function< |
There was a problem hiding this comment.
std::function is not considered as a good solution for non-tests code due to its performance drawbacks.
igor-egorov
reviewed
Apr 1, 2019
Signed-off-by: Mikhail Boldyrev <[email protected]>
Signed-off-by: Mikhail Boldyrev <[email protected]>
luckychess
approved these changes
Apr 2, 2019
igor-egorov
approved these changes
Apr 4, 2019
MBoldyrev
added a commit
that referenced
this pull request
Apr 8, 2019
Signed-off-by: Mikhail Boldyrev <[email protected]>
MBoldyrev
added a commit
that referenced
this pull request
Apr 8, 2019
Signed-off-by: Mikhail Boldyrev <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mikhail Boldyrev [email protected]
Description of the Change
New interface to access all batches and transactions of MST State.
Benefits
Copying can be avoided. Code simplified.
Possible Drawbacks
Usage Examples or Tests [optional]
Alternate Designs [optional]