This repository has been archived by the owner on Apr 17, 2019. It is now read-only.
Reorder validation rules in Postgres executor #2228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igor-egorov
requested review from
MBoldyrev,
lebdron and
luckychess
and removed request for
lebdron
MBoldyrev
approved these changes
Apr 15, 2019
Signed-off-by: Igor Egorov <[email protected]>
igor-egorov
force-pushed
the
fix/transfer-response-codes
branch
from
b41ec1d to
525dae1
Compare
luckychess
approved these changes
Apr 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Igor Egorov [email protected]
Description of the Change
Before the change, TransferAsset to non-existing account might lead to misleading error message "account does not have a permission". (Formally that was correct - "non-existing account does not have permissions at all")
Benefits
A correct error message will be produced: account does not exist or account does not have permission for each case correspondingly.
Usage Examples or Tests
all the tests