Reduce memory usage during Alter execution #9301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently use y.Throttle type to ensure that we do not concurrently build indexes for many predicates at the same time to avoid opening too many files on disk. This type allocates large memory initially to achieve this. By default, on my machine we allocate 128 MB of memory every time Alter is called. Now, Go is slow to release this memory back to OS increasing the memory usage. This PR sets the max to 1024 predicates at a time. It would be lower if Alter request involves fewer predicates in the request
github-actions
bot
added
area/core
harshil-goel
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently use y.Throttle type to ensure that we do not concurrently build indexes for many predicates at the same time to avoid opening too many files on disk. This type allocates large memory initially to achieve this. By default, on my machine we allocate 128 MB of memory every time Alter is called. Now, Go is slow to release this memory back to OS increasing the memory usage.
This PR sets the max to 1024 predicates at a time. It would be lower if Alter request involves fewer predicates in the request