Fix compilation of tests for out-of-tree-build #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have to modify the include path, otherwise I get | libconfig/tests/tests.c:31:10: fatal error: libconfig.h: No such file or directory | 31 | #include <libconfig.h> | | ^~~~~~~~~~~~~ | compilation terminated. Signed-off-by: Bernhard Walle <[email protected]>
| @@ -4,6 +4,8 @@ else() | |||
| set(libname "config") | |||
| endif() | |||
|
|
|||
| include_directories(${CMAKE_SOURCE_DIR}/lib) | |||
There was a problem hiding this comment.
The examples seem to use a different style, setting the include directory per-target:
target_include_directories(libconfig_tests PRIVATE ${CMAKE_SOURCE_DIR}/lib)
|
Can confirm for an out-of-tree build with CMake. |
hyperrealm
approved these changes
Dec 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have to modify the include path, otherwise I get
| libconfig/tests/tests.c:31:10: fatal error: libconfig.h: No such file or directory
| 31 | #include <libconfig.h>
| | ^~~~~~~~~~~~~
| compilation terminated.
Signed-off-by: Bernhard Walle [email protected]