feat(controller): Support cluster-preferred-endpoint-type valkey application configuration option

[kurtmc]

No description provided.

[dmolik]

LGTM!

[kurtmc]

@dmolik I noticed that in your zero-downtime-upgrades branch you are hardcoding this parameter to ip, see: https://github.com/hyperspike/valkey-operator/blob/zero-downtime-upgrades/internal/controller/scripts/valkey.conf#L1750

When I was doing some testing on our platform I noticed that the hostname option wasn't working, that's why I made this a parameter, I've used +kubebuilder:default:="hostname" to set the default value to hostname for backwards compatibility but perhaps we should set the default value to ip, what are your thoughts?

[dmolik]

hmmmm, yeah that seems reasonable. When the operator was still using the bitnami container, I had to flip it to hostname to get it to work with TLS, however I haven't seen the behavior return since switching to a more generic container, IE the Cluster Init changed significantly.

So two things then, yes let's go ahead and go with your suggestion of setting the default to ip

Can you add enum constraints to the field definition as well? Similar to here:

valkey-operator/api/v1/valkey_types.go

Line 117 in 47bb2ed

// +kubebuilder:validation:Enum=ClusterIssuer;Issuer

[dmolik]

Thanks for this one!!