autoenv_leave: Only match prefix on path boundaries #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Suppose we `cd` from `a/b` to `a/bz`. Expected behavior: Invoke `a/b/.env.leave. Actual behavior prior to this commit: No env-leave is invoked. The issue is that we are naively checking for string prefixes in `autoenv_leave` in order to determine whether one directory is an ancestor of another. This commit makes the checking slightly less naive.
tomtseng
commented
Jun 22, 2024
|
Thanks for the fix! I updated the patch to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suppose we
cdfroma/btoa/bz.Expected behavior: Invoke `a/b/.env.leave.
Actual behavior prior to this commit: No env-leave is invoked.
The issue is that we are naively checking for string prefixes in
autoenv_leavein order to determine whether one directory is an ancestor of another. This commit makes the checking slightly less naive by adding a trailing slash. This way,a/bz/is not a prefix of/a/b/.