Skip to content

Commit

Permalink
Move the spec exclude integration test from command to base.
Browse files Browse the repository at this point in the history
It is base-level functionality that has nothing to do with command.

Testing Done:
Integration test passed in its new location.

CI baking.

Reviewed at https://rbcommons.com/s/twitter/r/1449/
  • Loading branch information
benjyw authored and Benjy committed Dec 9, 2014
1 parent 643e89f commit 7a0d79a
Show file tree
Hide file tree
Showing 4 changed files with 17 additions and 19 deletions.
2 changes: 1 addition & 1 deletion tests/python/pants_test/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ target(
name = 'integration',
dependencies = [
'tests/python/pants_test/android:integration',
'tests/python/pants_test/commands:integration',
'tests/python/pants_test/base:integration',
'tests/python/pants_test/targets:integration',
'tests/python/pants_test/tasks:integration',
'tests/python/pants_test/python:integration',
Expand Down
17 changes: 16 additions & 1 deletion tests/python/pants_test/base/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,14 @@ python_test_suite(
name = 'all',
dependencies = [
':base',
],
]
)

python_test_suite(
name = 'integration',
dependencies = [
':test_spec_exclude_integration',
]
)

python_test_suite(
Expand Down Expand Up @@ -287,3 +294,11 @@ python_tests(
'src/python/pants/base:target',
]
)

python_tests(
name = 'test_spec_exclude_integration',
sources = [ 'test_spec_exclude_integration.py' ],
dependencies = [
'tests/python/pants_test:int-test',
]
)
17 changes: 0 additions & 17 deletions tests/python/pants_test/commands/BUILD

This file was deleted.

0 comments on commit 7a0d79a

Please sign in to comment.