Adding integrations test for the CLI commands related to pipelines. (k…

…ubeflow#125)

* First integration test for the ML Pipeline CLI (Pipeline List).

* Fixing an issue with an undefined variable

* Adding the --debug flag to help with debugging.

* Changing the namespace to Kubeflow.

* Adding integrations test for the CLI commands related to pipelines.

* Fix typo

* Addressing code review comments.

* Fixing imported json library in the CLI integration tests.

backend/src/cmd/ml/cmd/client_factory.go

@@ -1,6 +1,7 @@
 package cmd
 
 import (
+	"bytes"
 	"io"
 	"os"
 
@@ -20,10 +21,12 @@ type ClientFactoryInterface interface {
 		client.RunInterface, error)
 	Time() util.TimeInterface
 	Writer() io.Writer
+	Result() string
 }
 
 type ClientFactory struct {
 	time   util.TimeInterface
+	buffer *bytes.Buffer
 	writer io.Writer
 }
 
@@ -34,6 +37,15 @@ func NewClientFactory() *ClientFactory {
 	}
 }
 
+func NewClientFactoryWithByteBuffer() *ClientFactory {
+	buffer := new(bytes.Buffer)
+	return &ClientFactory{
+		time:   util.NewRealTime(),
+		buffer: buffer,
+		writer: buffer,
+	}
+}
+
 func (f *ClientFactory) CreatePipelineUploadClient(config clientcmd.ClientConfig, debug bool) (
 	client.PipelineUploadInterface, error) {
 	return client.NewPipelineUploadClient(config, debug)
@@ -61,3 +73,10 @@ func (f *ClientFactory) Time() util.TimeInterface {
 func (f *ClientFactory) Writer() io.Writer {
 	return f.writer
 }
+
+func (f *ClientFactory) Result() string {
+	if f.buffer == nil {
+		return "The writer is set to 'os.Stdout'. The result is not recorded."
+	}
+	return (*f.buffer).String()
+}

backend/src/cmd/ml/cmd/client_factory_fake.go

@@ -56,7 +56,7 @@ func (f *ClientFactoryFake) Result() string {
 	return (*f.buffer).String()
 }
 
-func getFakeRootCommand() (*RootCommand, *ClientFactoryFake) {
+func GetFakeRootCommand() (*RootCommand, *ClientFactoryFake) {
 	factory := NewClientFactoryFake()
 	rootCmd := NewRootCmd(factory)
 	rootCmd = CreateSubCommands(rootCmd, 10)

backend/src/cmd/ml/cmd/job.go

@@ -117,7 +117,7 @@ func NewJobCreateCmd(root *RootCommand) *cobra.Command {
 			if err != nil {
 				return util.ExtractErrorForCLI(err, root.Debug())
 			}
-			PrettyPrintResult(root.Writer(), root.NoColor(), root.OutputFormat(), job)
+			PrettyPrintResult(root.Writer(), root.OutputFormat(), job)
 			return nil
 		},
 	}
@@ -223,7 +223,7 @@ func NewJobGetCmd(root *RootCommand) *cobra.Command {
 			if err != nil {
 				return util.ExtractErrorForCLI(err, root.Debug())
 			}
-			PrettyPrintResult(root.Writer(), root.NoColor(), root.OutputFormat(), pkg)
+			PrettyPrintResult(root.Writer(), root.OutputFormat(), pkg)
 			return nil
 		},
 	}
@@ -259,7 +259,7 @@ func NewJobListCmd(root *RootCommand, pageSize int32) *cobra.Command {
 			if err != nil {
 				return util.ExtractErrorForCLI(err, root.Debug())
 			}
-			PrettyPrintResult(root.Writer(), root.NoColor(), root.OutputFormat(), results)
+			PrettyPrintResult(root.Writer(), root.OutputFormat(), results)
 			return nil
 		},
 	}
@@ -292,7 +292,7 @@ func NewJobEnableCmd(root *RootCommand) *cobra.Command {
 			if err != nil {
 				return util.ExtractErrorForCLI(err, root.Debug())
 			}
-			PrettyPrintResult(root.Writer(), root.NoColor(), root.OutputFormat(), "")
+			PrettyPrintResult(root.Writer(), root.OutputFormat(), "")
 			return nil
 		},
 	}
@@ -323,7 +323,7 @@ func NewJobDisableCmd(root *RootCommand) *cobra.Command {
 			if err != nil {
 				return util.ExtractErrorForCLI(err, root.Debug())
 			}
-			PrettyPrintResult(root.Writer(), root.NoColor(), root.OutputFormat(), "")
+			PrettyPrintResult(root.Writer(), root.OutputFormat(), "")
 			return nil
 		},
 	}
@@ -354,7 +354,7 @@ func NewJobDeleteCmd(root *RootCommand) *cobra.Command {
 			if err != nil {
 				return util.ExtractErrorForCLI(err, root.Debug())
 			}
-			PrettyPrintResult(root.Writer(), root.NoColor(), root.OutputFormat(), "")
+			PrettyPrintResult(root.Writer(), root.OutputFormat(), "")
 			return nil
 		},
 	}