Fsync after writing global seq number in ExternalSstFileIngestionJob

Summary: Fsync after writing global sequence number to the ingestion file in ExternalSstFileIngestionJob. Otherwise the file metadata could be incorrect. Closes facebook#3644 Differential Revision: D7373813 Pulled By: sagar0 fbshipit-source-id: 4da2c9e71a8beb5c08b4ac955f288ee1576358b8
iSynaptic · Mar 23, 2018 · 2e3d407 · 2e3d407
1 parent 4d51fea
commit 2e3d407
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/HISTORY.md b/HISTORY.md
@@ -5,7 +5,7 @@
 ### New Features
 
 ### Bug Fixes
-
+* Fsync after writing global seq number to the ingestion file in ExternalSstFileIngestionJob.
 
 ## 5.13.0 (3/20/2018)
 ### Public API Change

diff --git a/db/external_sst_file_ingestion_job.cc b/db/external_sst_file_ingestion_job.cc
@@ -510,6 +510,9 @@ Status ExternalSstFileIngestionJob::AssignGlobalSeqnoForIngestedFile(
   std::string seqno_val;
   PutFixed64(&seqno_val, seqno);
   status = rwfile->Write(file_to_ingest->global_seqno_offset, seqno_val);
+  if (status.ok()) {
+    status = rwfile->Fsync();
+  }
   if (status.ok()) {
     file_to_ingest->assigned_seqno = seqno;
   }