Skip to content
This repository has been archived by the owner on Dec 15, 2021. It is now read-only.

Add FastPlayerListPacket #1660

Merged
merged 1 commit into from
Aug 20, 2016
Merged

Add FastPlayerListPacket #1660

merged 1 commit into from
Aug 20, 2016

Conversation

Encritary
Copy link
Contributor

@Encritary Encritary commented Aug 16, 2016

Description




Fix PlayerListPacket bug in Nemisys.



### Reason to modify



I just replaces original PlayerListPacket with FastPlayerListPacket :3

### Tests & Reviews











There is only replaces MCPE packet with Synapse identical, I think it doesn't need a lot of tests.

@ishitatsuyuki ishitatsuyuki changed the title FastPlayerListPacket, are you here? Add FastPlayerListPacket Aug 16, 2016
@Encritary
Copy link
Contributor Author

@dktapps @PeratX

@ishitatsuyuki
Copy link
Member

Have you tested this? I and Dylan don't use Nemisys and are reluctant to setup it for test.

@dktapps
Copy link
Contributor

dktapps commented Aug 18, 2016

Seems a slight lack of activity from the people responsible for this project. Please be patient. I know next to nothing about Nemisys, I don't use it and it's not my field.

@Encritary
Copy link
Contributor Author

@PeratX and @boybook knows

@Yoyu666
Copy link

Yoyu666 commented Aug 18, 2016

what is this do?

@tarik02
Copy link
Contributor

tarik02 commented Aug 19, 2016

@Yoyu666, this fixes client freeze when playing though SPP and click back button.

@PeratX
Copy link
Member

PeratX commented Aug 20, 2016

Looks good. +1

Approved with PullApprove

@ishitatsuyuki
Copy link
Member

PeratX, filling a slot for you. Merge at your risk.

@PeratX
Copy link
Member

PeratX commented Aug 20, 2016

What do you mean.

@dktapps
Copy link
Contributor

dktapps commented Aug 20, 2016

A supplementary (untested) plus-one I think he means.

@PeratX
Copy link
Member

PeratX commented Aug 20, 2016

Tested. Working.

@dktapps
Copy link
Contributor

dktapps commented Aug 20, 2016

What happened to the PR formatting? Dear God. Well, whatever.

@dktapps dktapps merged commit 76062d2 into iTXTech:master Aug 20, 2016
@SleepSpace9
Copy link
Contributor

SleepSpace9 commented Aug 20, 2016

I got an error (server crash) on login now:

[15:44:23] [Server thread/INFO]: PillePalle[/x.x.x.x:23456] [ClientID: -9125418660827245104] logged in with entity id 1 at (Lobby, 17.5207, 5.4, -26.1701)

Notice: Undefined variable: sendTo in phar:///usr/games/pocketmine-lobby/Genisys_1.2dev.phar/src/synapse/network/protocol/spp/FastPlayerListPacket.php on line 29
[15:44:24] [Server thread/CRITICAL]: TypeError: "Argument 1 passed to pocketmine\utils\BinaryStream::putUUID() must be an instance of pocketmine\utils\UUID, null given, called in phar:///usr/games/pocketmine-lobby/Genisys_1.2dev.phar/src/synapse/network/protocol/spp/FastPlayerListPacket.php on line 29" (EXCEPTION) in "/src/pocketmine/utils/BinaryStream" at line 182
[15:44:24] [Server thread/EMERGENCY]: An unrecoverable error has occurred and the server has crashed. Creating a crash dump
[15:44:24] [Server thread/EMERGENCY]: Please upload the "/usr/games/pocketmine-lobby/crashdumps/CrashDump_Sat_Aug_20-15.44.24-CEST_2016.log" file to the Crash Archive and submit the link to the Bug Reporting page. Give as much info as you can.
[15:44:24] [Server thread/INFO]: Disabling SimpleAuth v1.7.1
...

@dktapps
Copy link
Contributor

dktapps commented Aug 20, 2016

@SleepSpace9 Please open a separate issue and reference this PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants