Added math equation support for plus and minus signs.

[mathieu-fournier]

Pull request for the issue feature #6935

Added initial support for parsing math equations. + and -

Plus and minus signs are supported.
Ex:
5 ft + 12 in + 1 yd -1 ft 6 in = 7.5 ft
(5 + 1 + 3 - 1.5)
Multiplication and division are not supported yet.

Special case + Refactoring

I noticed that the functions createQuantityFromParseTokens and getQuantityValueFromParseTokens where doing the same "tokens to value" logic. So I de-duplicated them.
There was one inconsistent output between these methods.
The case where only the unit label was specified. <- See line 601 in Parser.ts.
The output for the 2 methods where : 'FT' = 1 and 'FT' = 0
I opted to assume that the magnitude is 1.

Another special case, which I assume was a bug, is the parsing of 2'-6". <- See line 218 in the file Parsing.test.ts.
The minus sign was threated like a formatTraits fractionDash, but the format did not specified fractionDash, so it should've been 0 or error.
Now it's treated like a minus sign when fractionDash is NOT specified, and a fractionDash when fractionDah is specified.

[CLAassistant]

All committers have signed the CLA.

[anmolshres98]

Added initial support for parsing math equations. + and -

Plus and minus signs are supported. Ex: 5 ft + 12 in + 1 yd -1 ft 6 in = 7.5 ft (5 + 1 + 3 - 1.5) Multiplication and division are not supported yet.

In cases like these where multiple metrics are supplied (yd, ft, in, m, cm, ...) how do you decide on which to go with?

[mathieu-fournier]

Added initial support for parsing math equations. + and -

Plus and minus signs are supported. Ex: 5 ft + 12 in + 1 yd -1 ft 6 in = 7.5 ft (5 + 1 + 3 - 1.5) Multiplication and division are not supported yet.

In cases like these where multiple metrics are supplied (yd, ft, in, m, cm, ...) how do you decide on which to go with?

There are 2 cases :
1 - We use the specified unit given in the ParserSpec or Format parameter. (Usually the default unit displayed in the app, or a conversion to meters to work with the iModel.)
2 - If no default unit, we use the first unit encountered in the input string. (Like in the example above.)

[aruniverse]

Want to hold this PR and discuss motivations before merging this in

[aruniverse]

nit, maybe this is just an issue of wording or mu interpretation,

should it be mathematic operations not equations ? if so all references to the boolean flag you added need to be updated

[aruniverse]

where is the actual ts code for this? what does it look like?

[mathieu-fournier]

it's in the tests.
It looks like this :

// Async version 
const quantityProps = await Parser.parseIntoQuantity("2 FT 6 in + 9", format, unitsProvider);

// Sync version
const parseResult = Parser.parseToQuantityValue("2 FT 6 in + 9", format, meterConversionSpecs);

[aruniverse]

consumers will not be looking at the tests, theyll look at the the changelog here, and this should probably have a ts snippet of the change

[mathieu-fournier]

Users will use the quantity formatter with the boolean flag.
They will not call these directly. Should I add an example anyway ?

[mathieu-fournier]

Moved to #7019