Add a navigation bar #113
Open
Add a navigation bar #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report •
|
|
galuscakova
reviewed
Mar 31, 2024
| import { UserContext } from "../contexts/UserContext"; | ||
| import Container from "react-bootstrap/Container"; | ||
| import { BrowserRouter, Routes, Route } from "react-router-dom"; |
There was a problem hiding this comment.
Is order of the imported libraries correct? The same for Layout.tsx and Index.tsx.
There was a problem hiding this comment.
Imports are not reorganized based on ESLint sort-imports rule.
galuscakova
requested changes
Mar 31, 2024
| <Route path="/" element={<Layout />}> | ||
| <Route index element={<div>Welcome {user?.username}</div>} /> | ||
| {/* <Route path="service" element={<div>Service Management</div>} /> */} | ||
| <Route path="population" element={<div>Population form</div>} /> |
There was a problem hiding this comment.
Capitals: Population Form or Population PKG.
But the name is in both cases quite misleading.
There was a problem hiding this comment.
Updated to PKG Population.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A nagivation bar was added to navigate between the different features.
Typescripts files are formatted with Prettier.