The review URL was no longer being defaulted

oauthproxy.go

@@ -266,6 +266,9 @@ func (p *OAuthProxy) redeemCode(host, code string) (s *providers.SessionState, e
 
 	if s.Email == "" {
 		s.Email, err = p.provider.GetEmailAddress(s)
+		if err != nil {
+			err = fmt.Errorf("unable to update email from user info: %v", err)
+		}
 	}
 	return
 }
@@ -548,7 +551,7 @@ func (p *OAuthProxy) OAuthCallback(rw http.ResponseWriter, req *http.Request) {
 			p.ErrorPage(rw, 403, "Permission Denied", "Invalid Account")
 			return
 		}
-		log.Printf("%s error redeeming code %s", remoteAddr, err)
+		log.Printf("error redeeming code (client:%s): %s", remoteAddr, err)
 		p.ErrorPage(rw, 500, "Internal Error", "Internal Error")
 		return
 	}

providers/openshift/provider.go

@@ -262,6 +262,17 @@ func parseResources(resources string) (recordsByPath, error) {
 
 // Complete performs final setup on the provider or returns an error.
 func (p *OpenShiftProvider) Complete(data *providers.ProviderData, reviewURL *url.URL) error {
+	if emptyURL(reviewURL) {
+		if emptyURL(data.LoginURL) {
+			return fmt.Errorf("--openshift-review-url must be specified")
+		}
+		reviewURL = &url.URL{
+			Scheme: data.LoginURL.Scheme,
+			Host:   data.LoginURL.Host,
+			Path:   "/apis/authorization.openshift.io/v1/subjectaccessreviews",
+		}
+	}
+
 	p.ProviderData = data
 	p.ReviewURL = reviewURL