Skip to content

Commit

Permalink
Fix OSGi processor directive on aarch64 (netty#12498)
Browse files Browse the repository at this point in the history
Motivation:
OSGi has a limited set of permitted platform architecture names, which does not include `aarch_64` (with the underscore).

Modification:
Since our ARM builds use separate profiles, we can fix the hardcoded OSGi processor directive to use `aarch64` as it expects, without impacting our native code loading.

Result:
OSGi can now load our native code modules.
Except, probably, on FreeBSD and OpenBSD, which do not have separate ARM profiles and instead rely on our `os.detected.arch` which would include the underscore.
  • Loading branch information
chrisvest authored Jun 29, 2022
1 parent d0f8e73 commit 86d4ee4
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion resolver-dns-native-macos/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@
<addDefaultImplementationEntries>true</addDefaultImplementationEntries>
</manifest>
<manifestEntries>
<Bundle-NativeCode>META-INF/native/libnetty_resolver_dns_native_macos_aarch_64.jnilib; osname=MacOSX; processor=aarch_64</Bundle-NativeCode>
<Bundle-NativeCode>META-INF/native/libnetty_resolver_dns_native_macos_aarch_64.jnilib; osname=MacOSX; processor=aarch64</Bundle-NativeCode>
<Fragment-Host>io.netty.resolver-dns-classes-macos</Fragment-Host>
<Automatic-Module-Name>${javaModuleName}</Automatic-Module-Name>
</manifestEntries>
Expand Down
2 changes: 1 addition & 1 deletion transport-native-epoll/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -339,7 +339,7 @@
<addDefaultImplementationEntries>true</addDefaultImplementationEntries>
</manifest>
<manifestEntries>
<Bundle-NativeCode>META-INF/native/libnetty_transport_native_epoll_aarch_64.so; osname=Linux; processor=aarch_64,*</Bundle-NativeCode>
<Bundle-NativeCode>META-INF/native/libnetty_transport_native_epoll_aarch_64.so; osname=Linux; processor=aarch64,*</Bundle-NativeCode>
<Fragment-Host>io.netty.transport-classes-epoll</Fragment-Host>
<Automatic-Module-Name>${javaModuleName}</Automatic-Module-Name>
</manifestEntries>
Expand Down
2 changes: 1 addition & 1 deletion transport-native-kqueue/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@
<addDefaultImplementationEntries>true</addDefaultImplementationEntries>
</manifest>
<manifestEntries>
<Bundle-NativeCode>META-INF/native/libnetty_transport_native_kqueue_aarch_64.jnilib; osname=MacOSX; processor=aarch_64</Bundle-NativeCode>
<Bundle-NativeCode>META-INF/native/libnetty_transport_native_kqueue_aarch_64.jnilib; osname=MacOSX; processor=aarch64</Bundle-NativeCode>
<Fragment-Host>io.netty.transport-classes-kqueue</Fragment-Host>
<Automatic-Module-Name>${javaModuleName}</Automatic-Module-Name>
</manifestEntries>
Expand Down

0 comments on commit 86d4ee4

Please sign in to comment.