Skip deployment of testsuite jars (netty#11127)

Motivation: We should skip the deployment of jars that are not meant to be consumed by the user as there is no public API. Modifications: Let's skip deployment for modules that are not useful for users Result: Build cleanup
ible · Mar 30, 2021 · ff0c014 · ff0c014
1 parent 3706b73
commit ff0c014
Show file tree

Hide file tree

Showing 11 changed files with 24 additions and 7 deletions.
diff --git a/pom.xml b/pom.xml
@@ -403,6 +403,7 @@
     <!-- By default skip native testsuite as it requires a custom environment with graalvm installed -->
     <skipNativeImageTestsuite>true</skipNativeImageTestsuite>
     <skipShadingTestsuite>false</skipShadingTestsuite>
+    <skipDeploy>false</skipDeploy>
   </properties>
 
   <modules>
@@ -1176,6 +1177,7 @@
         <version>2.8.2</version>
         <configuration>
           <retryFailedDeploymentCount>10</retryFailedDeploymentCount>
+          <skip>${skipDeploy}</skip>
         </configuration>
       </plugin>
       <!-- After artifacts were deployed from linux and macos we need to execute the following on macOS (in the root of the project).

diff --git a/tarball/pom.xml b/tarball/pom.xml
@@ -27,6 +27,10 @@
   <packaging>pom</packaging>
 
   <name>Netty/Tarball</name>
+  <properties>
+    <!-- Do not deploy this module -->
+    <skipDeploy>true</skipDeploy>
+  </properties>
 
   <dependencies>
     <!-- The example depends on all modules either directly or transitively -->
@@ -83,13 +87,6 @@
           </execution>
         </executions>
       </plugin>
-      <!-- Do not deploy this module -->
-      <plugin>
-        <artifactId>maven-deploy-plugin</artifactId>
-        <configuration>
-          <skip>true</skip>
-        </configuration>
-      </plugin>
     </plugins>
   </build>
 

diff --git a/testsuite-autobahn/pom.xml b/testsuite-autobahn/pom.xml
@@ -30,6 +30,8 @@
 
   <properties>
     <skipJapicmp>true</skipJapicmp>
+    <!-- Do not deploy this module -->
+    <skipDeploy>true</skipDeploy>
   </properties>
 
   <dependencies>

diff --git a/testsuite-http2/pom.xml b/testsuite-http2/pom.xml
@@ -30,6 +30,8 @@
 
   <properties>
     <skipJapicmp>true</skipJapicmp>
+    <!-- Do not deploy this module -->
+    <skipDeploy>true</skipDeploy>
   </properties>
 
   <dependencies>

diff --git a/testsuite-native-image-client-runtime-init/pom.xml b/testsuite-native-image-client-runtime-init/pom.xml
@@ -30,6 +30,8 @@
 
   <properties>
     <skipJapicmp>true</skipJapicmp>
+    <!-- Do not deploy this module -->
+    <skipDeploy>true</skipDeploy>
   </properties>
 
   <dependencies>

diff --git a/testsuite-native-image-client/pom.xml b/testsuite-native-image-client/pom.xml
@@ -30,6 +30,8 @@
 
   <properties>
     <skipJapicmp>true</skipJapicmp>
+    <!-- Do not deploy this module -->
+    <skipDeploy>true</skipDeploy>
   </properties>
 
   <dependencies>

diff --git a/testsuite-native-image/pom.xml b/testsuite-native-image/pom.xml
@@ -30,6 +30,8 @@
 
   <properties>
     <skipJapicmp>true</skipJapicmp>
+    <!-- Do not deploy this module -->
+    <skipDeploy>true</skipDeploy>
   </properties>
 
   <dependencies>

diff --git a/testsuite-native/pom.xml b/testsuite-native/pom.xml
@@ -31,6 +31,8 @@
   <properties>
     <skipJapicmp>true</skipJapicmp>
     <skipNativeTestsuite>false</skipNativeTestsuite>
+    <!-- Do not deploy this module -->
+    <skipDeploy>true</skipDeploy>
   </properties>
 
   <dependencies>

diff --git a/testsuite-osgi/pom.xml b/testsuite-osgi/pom.xml
@@ -32,6 +32,8 @@
     <exam.version>4.13.0</exam.version>
     <argLine.java9.extras>--add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/jdk.internal.loader=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.security=ALL-UNNAMED</argLine.java9.extras>
     <skipJapicmp>true</skipJapicmp>
+    <!-- Do not deploy this module -->
+    <skipDeploy>true</skipDeploy>
   </properties>
 
   <profiles>

diff --git a/testsuite-shading/pom.xml b/testsuite-shading/pom.xml
@@ -39,6 +39,8 @@
     <jarName>${project.artifactId}-${project.version}.jar</jarName>
     <shadedPackagePrefix>io.netty.</shadedPackagePrefix>
     <skipJapicmp>true</skipJapicmp>
+    <!-- Do not deploy this module -->
+    <skipDeploy>true</skipDeploy>
   </properties>
 
   <build>

diff --git a/transport-blockhound-tests/pom.xml b/transport-blockhound-tests/pom.xml
@@ -76,6 +76,8 @@
     <!-- Needed for SelfSignedCertificate -->
     <argLine.java9.extras>--add-exports java.base/sun.security.x509=ALL-UNNAMED</argLine.java9.extras>
     <skipJapicmp>true</skipJapicmp>
+    <!-- Do not deploy this module -->
+    <skipDeploy>true</skipDeploy>
   </properties>
 
   <dependencies>