configs: Use known num in generic_nvme_drive (#72) #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't use $index in the D-Bus names, because EM can get confused by platform-fru-detect interactions and tries to put two instances of the same object path on D-Bus and will crash. Instead use SlotNumber, which is a property on the xyz.openbmc_project.Inventory.Decorator.Slot interface that will be on D-Bus on the drive inventory-manager path. Change-Id: I76b6bd5183a50a6c265bc151880c10adc7213a88 Signed-off-by: Matt Spinler <[email protected]> Change-Id: I178eab998e53e48c1d0823e262bcd3f21c0da136
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't use $index in the D-Bus names, because EM can get confused by platform-fru-detect interactions and tries to put two instances of the same object path on D-Bus and will crash.
Instead use SlotNumber, which is a property on the xyz.openbmc_project.Inventory.Decorator.Slot interface that will be on D-Bus on the drive inventory-manager path.
Change-Id: I76b6bd5183a50a6c265bc151880c10adc7213a88
Change-Id: I178eab998e53e48c1d0823e262bcd3f21c0da136