fix: use passed length as buffer size for binary array insert, issue #…

…896
ibmdb · Dec 18, 2022 · 773fde8 · 773fde8
1 parent 85d3246
commit 773fde8
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 6 deletions.
diff --git a/src/odbc.cpp b/src/odbc.cpp
@@ -1153,11 +1153,18 @@ void ODBC::GetBufferParam(Local<Value> value, Parameter * param, int num)
 {
     DEBUG_PRINTF("ODBC::GetBufferParam - It's a buffer.\n");
     param->buffer = (char *) Buffer::Data(value);
-    param->size          = Buffer::Length(value);
-    param->buffer_length = param->size;
-    param->length        = param->buffer_length;
+    param->length = Buffer::Length(value);
+    int bufflen = param->length;
     param->isBuffer      = true; // Dont free it in FREE_PARAMS
 
+    if(bufflen <= param->buffer_length &&
+       ((param->paramtype % 2 == 0) || (param->arraySize > 0)))
+    {
+        bufflen = param->buffer_length;
+    }
+    param->buffer_length = bufflen;
+    param->size = bufflen;
+
     if(!param->c_type || (param->c_type == SQL_CHAR))
         param->c_type = SQL_C_TCHAR;
     #ifdef UNICODE

diff --git a/test/test-binary-array-insert.js b/test/test-binary-array-insert.js
@@ -16,10 +16,10 @@ async function main() {
 	console.log(results)
 
 	const data = [
-      '628bacf012d4628bacf012d4',
+      '628bacf012d4628bacd4',
       '628bacf012d5628bacf012d5',
-      '628bacf012d6628bacf012d6',
-      '628bacf012d7628bacf012d7',
+      '628bacf012d6628bacf0d6',
+      '628bacf012d7628bacf0d7',
       '628bacf012d8628bacf012d8'
     ]
 	ibmdb.debug(2);