fix: ignore CLI0106E error for endTransaction, issue #938

lib/odbc.js

@@ -1190,13 +1190,13 @@ Database.prototype.endTransactionSync = function (rollback)
 {
   var self = this;
 
+  self.conn.inTransaction = false;
   try {
     self.conn.endTransactionSync(rollback);
   } catch (e) {
     self.checkConnectionError(e);
     throw new Error(e);
   }
-  self.conn.inTransaction = false;
 
   return self;
 };
@@ -2719,7 +2719,11 @@ Database.prototype.poolCloseSync = function ()
     // the pool. So that, next request can get afresh connection from pool.
     if(db.conn && db.conn.inTransaction)
     {
+      try {
         db.rollbackTransactionSync();
+      } catch(error) {
+          // Just ignore the error, since we're closing the connection.
+      }
     }
 
     //remove this db from the usedPool
@@ -2737,7 +2741,7 @@ Database.prototype.poolCloseSync = function ()
 
     if(db.conn && self.options.autoCleanIdle) self.cleanUp(connStr);
     return self.queue.next();
-};  // db.closeSync function
+};  // db.poolCloseSync function
 
 // conn.close function for pooled connection.
 Database.prototype.poolClose = function (cb)

test/test-pool-stale-connections.js

@@ -29,6 +29,7 @@ var timer = setInterval(function() {
             console.log("Connection " + err.toString());
         }
 
+        connection.beginTransactionSync();
         connection.query("select 1 from sysibm.sysdummy1", 
           function (err, results) {
             if (err) {
@@ -37,6 +38,7 @@ var timer = setInterval(function() {
             }else{
                 console.log(JSON.stringify(results));
                 assert.equal(JSON.stringify(results), '[{"1":1}]');
+                connection.commitTransactionSync();
             }
             connection.close(function () {
               console.log('Connection closed');