Skip to content

Commit

Permalink
Add release build to RocksDB per-diff/post-commit tests
Browse files Browse the repository at this point in the history
Summary: To make sure that we'll have additional verification for release builds, define a new category and add `make release` to per-diff/post-commit tests. This should in theory prevent the release MyRocks integration builds breaks from happening.

Test Plan:
- `[p]arc diff --preview`
- Observe the execution in Sandcastle and make sure that release build and tests are executed.

Reviewers: sdong

Reviewed By: sdong

Subscribers: andrewkr, dhruba

Differential Revision: https://reviews.facebook.net/D60441
  • Loading branch information
Gunnar Kudrjavets committed Jul 8, 2016
1 parent 907f24d commit 61dbfbb
Show file tree
Hide file tree
Showing 3 changed files with 25 additions and 1 deletion.
2 changes: 1 addition & 1 deletion arcanist_util/config/RocksDBCommonHelper.php
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ function startTestsInSandcastle($applyDiff, $workflow, $diffID) {
// Manually list of tests we want to run in Sandcastle.
$tests = array(
"unit", "unit_481", "clang_unit", "tsan", "asan", "lite_test",
"valgrind"
"valgrind", "release"
);
}

Expand Down
1 change: 1 addition & 0 deletions build_tools/error_filter.py
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,7 @@ def __init__(self):
_TEST_NAME_TO_PARSERS = {
'punit': [CompilerErrorParser, GTestErrorParser],
'unit': [CompilerErrorParser, GTestErrorParser],
'release': [CompilerErrorParser, GTestErrorParser],
'unit_481': [CompilerErrorParser, GTestErrorParser],
'clang_unit': [CompilerErrorParser, GTestErrorParser],
'clang_analyze': [CompilerErrorParser, ScanBuildErrorParser],
Expand Down
23 changes: 23 additions & 0 deletions build_tools/rocksdb-lego-determinator
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,26 @@ UNIT_TEST_COMMANDS="[
}
]"

#
# RocksDB release build and unit tests
#
RELEASE_UNIT_TEST_COMMANDS="[
{
'name':'Rocksdb Release Unit Test',
'oncall':'$ONCALL',
'steps': [
$CLEANUP_ENV,
{
'name':'Build and test RocksDB debug version',
'shell':'$SHM $DEBUG make J=1 release',
'user':'root',
$PARSER
},
],
$REPORT
}
]"

#
# RocksDB unit test on gcc-4.8.1
#
Expand Down Expand Up @@ -665,6 +685,9 @@ case $1 in
unit)
echo $UNIT_TEST_COMMANDS
;;
release)
echo $RELEASE_UNIT_TEST_COMMANDS
;;
unit_481)
echo $UNIT_TEST_COMMANDS_481
;;
Expand Down

0 comments on commit 61dbfbb

Please sign in to comment.