Skip to content

Commit

Permalink
use IconDocument for pages in planner
Browse files Browse the repository at this point in the history
instead of IconMsWord

test plan: the expected icon should be used for pages with todo dates
in both the todo sidebar and the planner dashboard

(inspect element and see the SVG name is "IconDocument" to be sure)

fixes ADMIN-1257

Change-Id: I72671324b9bcbe28bb4cc50939804966a214823b
Reviewed-on: https://gerrit.instructure.com/165305
Tested-by: Jenkins
Reviewed-by: Ed Schiebel <[email protected]>
QA-Review: Jon Willesen <[email protected]>
Product-Review: Jeremy Stanley <[email protected]>
  • Loading branch information
jstanley0 committed Sep 24, 2018
1 parent b39a002 commit 669495b
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -2589,7 +2589,7 @@ exports[`renders Note correctly with Group 1`] = `
}
}
>
<IconMsWord />
<IconDocument />
</div>
<div>
<div>
Expand Down Expand Up @@ -3037,7 +3037,7 @@ exports[`renders Page correctly with everything 1`] = `
}
}
>
<IconMsWord />
<IconDocument />
</div>
<div>
<div>
Expand Down Expand Up @@ -3185,7 +3185,7 @@ exports[`renders Page correctly with just date 1`] = `
}
}
>
<IconMsWord />
<IconDocument />
</div>
<div>
<div>
Expand Down Expand Up @@ -3309,7 +3309,7 @@ exports[`renders Page correctly with just points 1`] = `
}
}
>
<IconMsWord />
<IconDocument />
</div>
<div>
<div>
Expand Down Expand Up @@ -3457,7 +3457,7 @@ exports[`renders Page correctly without right side content 1`] = `
}
}
>
<IconMsWord />
<IconDocument />
</div>
<div>
<div>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ import Quiz from '@instructure/ui-icons/lib/Line/IconQuiz';
import Announcement from '@instructure/ui-icons/lib/Line/IconAnnouncement';
import Discussion from '@instructure/ui-icons/lib/Line/IconDiscussion';
import Calendar from '@instructure/ui-icons/lib/Line/IconCalendarMonth';
import Page from '@instructure/ui-icons/lib/Line/IconMsWord';
import Page from '@instructure/ui-icons/lib/Line/IconDocument';
import Edit from '@instructure/ui-icons/lib/Line/IconEdit';
import PeerReview from '@instructure/ui-icons/lib/Line/IconPeerReview';
import NotificationBadge, { MissingIndicator, NewActivityIndicator } from '../NotificationBadge';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ import AnnouncementIcon from '@instructure/ui-icons/lib/Line/IconAnnouncement';
import DiscussionIcon from '@instructure/ui-icons/lib/Line/IconDiscussion';
import NoteIcon from '@instructure/ui-icons/lib/Line/IconNote';
import CalendarIcon from '@instructure/ui-icons/lib/Line/IconCalendarMonth';
import PageIcon from '@instructure/ui-icons/lib/Line/IconMsWord';
import PageIcon from '@instructure/ui-icons/lib/Line/IconDocument';
import PeerReviewIcon from '@instructure/ui-icons/lib/Line/IconPeerReview';

import { formatDateAtTimeWithoutYear } from '../../utilities/dateUtils';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ it('renders page icon for pages', () => {
const wrapper = shallow(
<ToDoItem {...getDefaultProps({ type: 'Page' })} />
);
expect(wrapper.find('IconMsWord').exists()).toBe(true);
expect(wrapper.find('IconDocument').exists()).toBe(true);
});

it('renders peer review icon for peer reviews', () => {
Expand Down

0 comments on commit 669495b

Please sign in to comment.