Skip to content

Commit

Permalink
turn off webpack progress for less noisy builds
Browse files Browse the repository at this point in the history
This patchset also enables linting of webpack development to ensure es6
compatability. Before this patchset, gulp was invoked with an ampersand
to make it a background process. However since it only takes a few
seconds to run, it's success messages would be interlaced with webpack's
output. This reads rather odd in our logs. Since gulp is a low-churn
tool in canvas, let's mute stdout but still display stderr if an error
should appear.

Change-Id: I48846758e839480c9bc5779bfe64201e90713e2b
Reviewed-on: https://gerrit.instructure.com/170833
Tested-by: Jenkins
Reviewed-by: Rex Fleischer <[email protected]>
QA-Review: Derek Bender <[email protected]>
Product-Review: Derek Bender <[email protected]>
  • Loading branch information
djbender committed Nov 5, 2018
1 parent be2db93 commit df371fb
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -228,8 +228,8 @@
"build:packages": "yarn workspace-run build:canvas",
"lint:browser-code": "es-check es5 ./public/dist/**/*.js",
"postinstall": "yarn build:packages",
"webpack": "gulp rev & webpack --progress --color --watch",
"webpack-development": "gulp rev & webpack --progress --color",
"webpack": "gulp rev 1> /dev/null & webpack --progress --color --watch",
"webpack-development": "gulp rev 1> /dev/null & webpack --color && yarn lint:browser-code",
"webpack-production": "NODE_ENV=production gulp rev && node --max_old_space_size=4096 $(yarn bin)/webpack --color --config webpack.production.config.js && yarn lint:browser-code",
"workspace-run": "r() { wsrun $@ --fast-exit --exclude-missing --collect-logs --report; exit $?; } && r",
"jspec": "./spec/jspec.sh",
Expand Down

0 comments on commit df371fb

Please sign in to comment.