Skip to content

Commit

Permalink
don't use a different default when calling sis num_strand setting
Browse files Browse the repository at this point in the history
g/167863 will keep the default from getting stored in multicache
but it can still collide in the in-process cache

closes #CORE-1977

Change-Id: Ic29292ad1da69af9684862a934698ed73d001937
Reviewed-on: https://gerrit.instructure.com/167920
Tested-by: Jenkins
Reviewed-by: Cody Cutrer <[email protected]>
QA-Review: James Williams <[email protected]>
Product-Review: James Williams <[email protected]>
  • Loading branch information
maneframe committed Oct 12, 2018
1 parent 6b0114e commit f5263df
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/sis/csv/import_refactored.rb
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ def initialize(root_account, opts = {})
@finished = false

settings = PluginSetting.settings_for_plugin('sis_import')
parallel = Setting.get("sis_parallel_import/#{@root_account.global_id}_num_strands", "1")
parallel = Setting.get("sis_parallel_import/#{@root_account.global_id}_num_strands", nil).presence || "1"
if settings.dig(:parallelism).to_i > 1 && settings[:parallelism] != parallel
Setting.set("sis_parallel_import/#{@root_account.global_id}_num_strands", settings[:parallelism])
end
Expand Down

0 comments on commit f5263df

Please sign in to comment.