Should use if, not unless

ibroadfo · Feb 21, 2014 · 54fc3de · 54fc3de
1 parent 4bf591c
commit 54fc3de
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/lib/billy/handlers/cache_handler.rb b/lib/billy/handlers/cache_handler.rb
@@ -12,7 +12,7 @@ def self.cache
 
     def handle_request(method, url, headers, body)
       method = method.downcase
-      unless handles_request?(method, url, headers, body)
+      if handles_request?(method, url, headers, body)
         if (response = cache.fetch(method, url, body))
           Billy.log(:info, "puffing-billy: CACHE #{method} for '#{url}'")
           return response

diff --git a/lib/billy/handlers/proxy_handler.rb b/lib/billy/handlers/proxy_handler.rb
@@ -10,7 +10,7 @@ def handles_request?(method, url, headers, body)
     end
 
     def handle_request(method, url, headers, body)
-      unless handles_request?(method, url, headers, body)
+      if handles_request?(method, url, headers, body)
         req = EventMachine::HttpRequest.new(url)
         build_request_options(headers, body).tap do |opts|
           req = req.send(method.downcase, build_request_options(headers, body))

diff --git a/lib/billy/handlers/stub_handler.rb b/lib/billy/handlers/stub_handler.rb
@@ -5,7 +5,7 @@ class StubHandler
     include Handler
 
     def handle_request(method, url, headers, body)
-      unless handles_request?(method, url, headers, body)
+      if handles_request?(method, url, headers, body)
         if (stub = find_stub(method, url))
           query_string = URI.parse(url).query || ""
           params = CGI.parse(query_string)