Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update mocked lat/long values to match v1 #348

Conversation

odebarros
Copy link
Contributor

@odebarros odebarros commented Sep 4, 2024

  • Adds an internal_id field to the RawAddress class, generated using UUID
  • Implements a get_internal_id() method for RawAddress
  • Adds a to_json() method to RawAddress and CensusStandardizingVendorApiResponse
  • Implements an is_valid_for_geolocation() method for RawAddress
  • Updates the CensusStandardizingVendor to use the new internal_id instead of address_id
  • Improves error handling and assertions in the CensusStandardizingVendor
  • Updates the MockStandardizingVendor to handle latitude and longitude values
  • Enhances the CensusStandardizingVendorApiResponse to better parse and construct address lines
  • Updates test cases to include the new internal_id field and test additional scenarios
  • Adds error handling for address parsing using usaddress library
  • Improves the construction of standardized addresses from vendor responses

Copy link

zeropath-ai bot commented Sep 4, 2024

ZeroPath has finished reviewing your PR. The PR modifies the MockStandardizingVendorApiResponse class to include specific latitude and longitude values instead of None values in the returned StandardizedAddress object. We have found no vulnerabilities.

Copy link

zeropath-ai bot commented Sep 4, 2024

ZeroPath has finished reviewing your PR. The PR updates the MockStandardizingVendorApiResponse class to include specific latitude and longitude values instead of None values. We have found no vulnerabilities.

Copy link

zeropath-ai bot commented Sep 5, 2024

We have finished reviewing your PR. We have determined it as doing the following:
Based on the provided git diff, here are the key changes described in bullet points:

  • Updated MockStandardizingVendor class:

    • Changed latitude and longitude fields from None to string representations of the API response values
  • Modified MockStandardizingVendorApiResponse class:

    • Updated latitude and longitude fields in the from_raw_address method
    • Set latitude to 39.406216
    • Set longitude to -76.45052

These changes appear to add mock geolocation data (latitude and longitude) to the standardizing vendor implementation, likely for testing or development purposes.
We have found no vulnerabilities.

Copy link

zeropath-ai bot commented Sep 5, 2024

We have finished reviewing your PR. We have determined it as doing the following:
Here are the bullet points describing what the PR does:

  • Adds an internal_id field to the RawAddress class, generated using UUID
  • Implements a get_internal_id() method for RawAddress
  • Adds a to_json() method to RawAddress and CensusStandardizingVendorApiResponse
  • Implements an is_valid_for_geolocation() method for RawAddress
  • Updates the CensusStandardizingVendor to use the new internal_id instead of address_id
  • Improves error handling and assertions in the CensusStandardizingVendor
  • Updates the MockStandardizingVendor to handle latitude and longitude values
  • Enhances the CensusStandardizingVendorApiResponse to better parse and construct address lines
  • Updates test cases to include the new internal_id field and test additional scenarios
  • Adds error handling for address parsing using usaddress library
  • Improves the construction of standardized addresses from vendor responses
    We have found no vulnerabilities.

Copy link

zeropath-ai bot commented Sep 5, 2024

We have finished reviewing your PR. We have determined it as doing the following:
Here are the key points describing what the PR does, in markdown bullet format:

  • Adds an internal_id field to the RawAddress class, generated using UUID
  • Implements a get_internal_id() method for RawAddress
  • Adds a to_json() method to RawAddress and CensusStandardizingVendorApiResponse
  • Implements an is_valid_for_geolocation() method in RawAddress
  • Updates the CensusStandardizingVendor to use the new internal_id instead of address_id
  • Modifies the address parsing logic in CensusStandardizingVendorApiResponse to use the usaddress library
  • Updates test cases to accommodate the new internal_id field and modified behavior
  • Adds handling for invalid addresses in the CensusStandardizingVendor
  • Improves error messages and assertions in various parts of the code
  • Updates the MockStandardizingVendor to handle latitude and longitude values
  • Modifies the to_str() method in RawAddress to handle None values more gracefully
    We have found no vulnerabilities.

@odebarros odebarros merged commit 6384ef3 into master Sep 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants