-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update mocked lat/long values to match v1 #348
update mocked lat/long values to match v1 #348
Conversation
odebarros
commented
Sep 4, 2024
•
edited by imranq2
Loading
edited by imranq2
- Adds an internal_id field to the RawAddress class, generated using UUID
- Implements a get_internal_id() method for RawAddress
- Adds a to_json() method to RawAddress and CensusStandardizingVendorApiResponse
- Implements an is_valid_for_geolocation() method for RawAddress
- Updates the CensusStandardizingVendor to use the new internal_id instead of address_id
- Improves error handling and assertions in the CensusStandardizingVendor
- Updates the MockStandardizingVendor to handle latitude and longitude values
- Enhances the CensusStandardizingVendorApiResponse to better parse and construct address lines
- Updates test cases to include the new internal_id field and test additional scenarios
- Adds error handling for address parsing using usaddress library
- Improves the construction of standardized addresses from vendor responses
ZeroPath has finished reviewing your PR. The PR modifies the MockStandardizingVendorApiResponse class to include specific latitude and longitude values instead of None values in the returned StandardizedAddress object. We have found no vulnerabilities. |
ZeroPath has finished reviewing your PR. The PR updates the MockStandardizingVendorApiResponse class to include specific latitude and longitude values instead of None values. We have found no vulnerabilities. |
We have finished reviewing your PR. We have determined it as doing the following:
These changes appear to add mock geolocation data (latitude and longitude) to the standardizing vendor implementation, likely for testing or development purposes. |
We have finished reviewing your PR. We have determined it as doing the following:
|
We have finished reviewing your PR. We have determined it as doing the following:
|