Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Health Data #60

Merged
merged 72 commits into from
Jul 22, 2024
Merged

Implement Health Data #60

merged 72 commits into from
Jul 22, 2024

Conversation

kylewadebwell
Copy link
Contributor

This PR started with the intention of adding allergy intolerances to the sample app and ended up including all of the health data endpoints. It would be good to get a second set of eyes on this.

Plans for next steps for this code after this PR:

  1. Add unit tests for the components following the patterns in "Mastering React TDD"
  2. Add additional e2e tests
  3. Add remaining TS SDK methods

@kylewadebwell
Add allergy intolerance groups
f437ef7
@kylewadebwell
Add ability to show json or table
1e45f99
@kylewadebwell
Handle errors and pending state
068fa98
@kylewadebwell
Fix imports, minor refactor
2710271
@kylewadebwell
Minor refactor
e40b2e4
@kylewadebwell
Use a ToggleButtonGroup rather than a Button
327359e
@kylewadebwell
Move toggle into a reusable component with Redux state, simplify Alle…
c39aee6 
…rgy Intolerances page further
@kylewadebwell
Initialize toggle state on mount, add getAllergyIntolerances request
d58465a
@kylewadebwell
Initialize a default rather than using a side effect
0f3cd97
@kylewadebwell
Add mui datagrid reference; add Connections page, Redux stuff and exa…
67a42ad 
…mple of getConnections; add getAllergyIntolerances
@kylewadebwell
Fix dates in datagrid
e67605e
@kylewadebwell
Rewrite Allergy Intolerance Groups to use DataGrid; remove Allergy In…
6ab1af6 
…tolerances in order to re-implement it
@kylewadebwell
Remove Hello page, add withAuthCheck HOC, use server pagination in mu…
f3ba29d 
…i datagrid
@kylewadebwell
Add state persistence to local storage, logout feature, refactor out …
4b8b6cd 
…initializationSlice
@kylewadebwell
Minor bug fixes and refactors
6ccecfe
@kylewadebwell
Fix SDK rehydration; add allergy intolerances; add bottom page margin
7d657a9
@kylewadebwell
Remove unused stuff
e7124d3
@kylewadebwell
Remove unused code
66d8787
@kylewadebwell
Refactor to make more reusable components
f7b8dfd
@kylewadebwell
Remove getSdk's reliance on state; remove logging
21c3b85
@kylewadebwell
Fix tableOrJsonToggle
bdf3ae2
@kylewadebwell
Fix rehydration error message logic, no longer need to await getSdk
1a48023
@kylewadebwell
Remove console logging, add Health Summary
873ccbc
@kylewadebwell
Add Conditions
329f07d
@kylewadebwell
Adjust table
10f9d35
@kylewadebwell
Add spaces to menu
4b06d37
@kylewadebwell
Add columns to AllergyIntoleranceGroups
af0e890
@kylewadebwell
Add source to condition groups
0b42f22
@kylewadebwell
Add Labs
24ea78c
@kylewadebwell
Add referenceRange to Labs
aaa86d6
@kylewadebwell kylewadebwell requested a review from wootencl July 22, 2024 14:15
wootencl
wootencl reviewed Jul 22, 2024
View reviewed changes
Copy link
Collaborator

@wootencl wootencl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to document how to set the proper env vars so things are working in respect to init/auth.

bwell-typescript-react/package.json Outdated Show resolved Hide resolved
bwell-typescript-react/README.md Outdated
See also: https://playwright.dev/docs/docker

## How to test SDK code under development
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need to be moved to the bwell-sdk repo. This repo is public facing so these instructions won't be applicable to non bwell folks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Updated the Readme and added a couple of notes about how to use the app.

@kylewadebwell kylewadebwell merged commit 6510bce into main Jul 22, 2024
1 check passed
@kylewadebwell kylewadebwell deleted the allergy-intolerances branch July 22, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wootencl wootencl wootencl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kylewadebwell @wootencl