bug fix

icezheng · Nov 2, 2014 · 4004f2f · 4004f2f
1 parent 5eed982
commit 4004f2f
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 6 deletions.
diff --git a/AndroidManifest.xml b/AndroidManifest.xml
@@ -1,7 +1,7 @@
 <manifest xmlns:android="http://schemas.android.com/apk/res/android"
     package="com.cundong.izhihu"
-    android:versionCode="13"
-    android:versionName="2.1.3" >
+    android:versionCode="14"
+    android:versionName="2.1.4" >
 
     <uses-permission android:name="android.permission.INTERNET" />
     <uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" />

diff --git a/src/com/cundong/izhihu/activity/NewsDetailActivity.java b/src/com/cundong/izhihu/activity/NewsDetailActivity.java
@@ -159,8 +159,7 @@ public boolean onOptionsItemSelected(MenuItem item) {
 					share_url = mNewsEntity.share_url;
 				}
 
-				if (!TextUtils.isEmpty(title) && !TextUtils.isEmpty(image)
-						&& !TextUtils.isEmpty(share_url)) {
+				if (!TextUtils.isEmpty(title) && !TextUtils.isEmpty(share_url)) {
 					ZhihuApplication.getNewsFavoriteDataSource().add2Favorite(
 							String.valueOf(mNewsId), title, image, share_url);
 

diff --git a/src/com/cundong/izhihu/fragment/NewsListFragment.java b/src/com/cundong/izhihu/fragment/NewsListFragment.java
@@ -95,7 +95,7 @@ public void onScroll(AbsListView view, int firstVisibleItem,
 
 				if (lastItem == totalItemCount) {
 					if (mListViewPreLast != lastItem) { // to avoid multiple calls for
-												// last item
+														// last item
 
 						mCalendar.add(Calendar.DAY_OF_YEAR, -1);
 
@@ -126,6 +126,8 @@ private class LoadCacheNewsTask extends MyAsyncTask<String, Void, ArrayList<News
 		@Override
 		protected ArrayList<NewsEntity> doInBackground(String... params) {
 
+			//TODO 或许这是一个BUG
+
 			/*
 			 * 当前策略：
 			 * 

diff --git a/src/com/cundong/izhihu/util/Logger.java b/src/com/cundong/izhihu/util/Logger.java
@@ -13,7 +13,7 @@ public class Logger {
 	/**
 	 * debug or not
 	 */
-	private static boolean debug = false;
+	private static boolean debug = true;
 
 	private static Logger instance = new Logger();