Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guarded against NaN in LinearInterpolation #30159

Merged
merged 2 commits into from
Mar 28, 2025

Conversation

joshuahansel
Copy link
Contributor

This was broken by #24256

Closes #30157

@joshuahansel joshuahansel self-assigned this Mar 20, 2025
@moosebuild
Copy link
Contributor

moosebuild commented Mar 21, 2025

Job Documentation, step Docs: sync website on c44056f wanted to post the following:

View the site here

This comment will be updated on new commits.

@moosebuild
Copy link
Contributor

moosebuild commented Mar 21, 2025

Job Coverage, step Generate coverage on c44056f wanted to post the following:

Framework coverage

dbbe0b #30159 c44056
Total Total +/- New
Rate 85.28% 85.28% +0.00% 100.00%
Hits 109403 109407 +4 8
Misses 18887 18887 - 0

Diff coverage report

Full coverage report

Modules coverage

Coverage did not change

Full coverage reports

Reports

This comment will be updated on new commits.

@joshuahansel joshuahansel marked this pull request as ready for review March 24, 2025 22:30
@joshuahansel joshuahansel requested a review from lindsayad as a code owner March 24, 2025 22:30
@joshuahansel
Copy link
Contributor Author

@lindsayad Just marked as ready. I confirmed this will fix the valgrind target in Sockeye.

@joshuahansel joshuahansel merged commit c3545ae into idaholab:next Mar 28, 2025
50 of 51 checks passed
@joshuahansel joshuahansel deleted the linear-interp-test branch March 28, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LinearInterpolation can access out of bounds with NaN input
3 participants