forked from puppeteer/puppeteer
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore(doclint): fix doclint tests (puppeteer#941)
Last commit 017429e broke doclint tests. Try bots didn't catch this because they were not running doclint tests. This patch: - fixes doclint tests - starts running doclint tests on travis
- Loading branch information
1 parent
017429e
commit dc4c878
Showing
7 changed files
with
8 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,8 +10,6 @@ | |
|
||
#### foo.ddd | ||
|
||
#### new Foo() | ||
|
||
#### foo.ccc() | ||
|
||
#### foo.bbb() |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,4 @@ | ||
[MarkDown] Events should go first. Event 'b' in class Foo breaks order | ||
[MarkDown] Constructor of Foo should go before other methods | ||
[MarkDown] Event 'c' in class Foo breaks alphabetic ordering of events | ||
[MarkDown] Bad alphabetic ordering of Foo members: Foo.ddd should go after Foo.constructor() | ||
[MarkDown] Bad alphabetic ordering of Foo members: Foo.ddd should go after Foo.ccc() | ||
[MarkDown] Bad alphabetic ordering of Foo members: Foo.ccc() should go after Foo.bbb() |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,11 @@ | ||
### class: Foo | ||
#### new Foo(arg1, arg2) | ||
- `arg1` <[string]> | ||
- `arg2` <[string]> | ||
|
||
#### foo.bar(options) | ||
- `options` <[Object]> | ||
|
||
#### foo.foo(arg1, arg2) | ||
- `arg1` <[string]> | ||
- `arg2` <[string]> | ||
|
||
#### foo.test(...files) | ||
- `...filePaths` <[string]> | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
class Foo { | ||
constructor(arg1, arg3 = {}) { | ||
foo(arg1, arg3 = {}) { | ||
} | ||
|
||
test(...filePaths) { | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
[MarkDown] Heading arguments for "foo.test(...files)" do not match described ones, i.e. "...files" != "...filePaths" | ||
[MarkDown] Method Foo.constructor() fails to describe its parameters: | ||
[MarkDown] Method Foo.foo() fails to describe its parameters: | ||
- Argument not found: arg3 | ||
- Non-existing argument found: arg2 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,2 @@ | ||
[MarkDown] Method not found: Foo.constructor() | ||
[MarkDown] Non-existing property found: Foo.c | ||
[MarkDown] Property not found: Foo.b |