Fix null reference bug (palantir#1346)

Closes palantir#1345
idriss92 · Jun 25, 2016 · 81b8d7e · 81b8d7e
1 parent 4fc600b
commit 81b8d7e
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/src/rules/typedefRule.ts b/src/rules/typedefRule.ts
@@ -157,7 +157,7 @@ class TypedefWalker extends Lint.RuleWalker {
 
         // If this is an arrow function, it doesn't need to have a typedef on the property declaration
         // as the typedefs can be on the function's parameters instead
-        const performCheck = !(node.initializer.kind === ts.SyntaxKind.ArrowFunction && node.type == null);
+        const performCheck = !(node.initializer != null && node.initializer.kind === ts.SyntaxKind.ArrowFunction && node.type == null);
 
         if (performCheck) {
             this.checkTypeAnnotation(optionName, node.name.getEnd(), node.type, node.name);

diff --git a/test/rules/typedef/all/test.ts.lint b/test/rules/typedef/all/test.ts.lint
@@ -80,3 +80,10 @@ someFunc(n => n+1);
           ~        [expected arrow-parameter: 'n' to have a typedef]
 someFunc(n => {});
           ~        [expected arrow-parameter: 'n' to have a typedef]
+
+class A {
+    // property w/o an initializer
+    public foo;
+              ~ [expected member-variable-declaration: 'foo' to have a typedef]
+    private bar: number;
+}