Skip to content

Commit

Permalink
usb: misc: usb3503: Remove 100ms sleep on reset, conform to data sheet
Browse files Browse the repository at this point in the history
The usb3503 driver sleeps a flat 100ms when resetting the chip, with a
comment about waiting for the reference clock. This seems to be a
board-specific detail that should not hold up boot across all platforms.
This patch reduces the sleep to the 4ms initialization delay that the
chip itself actually requires (as per its data sheet). If certain boards
require more time to set up the reference clock, they should change this
through local patches or add a proper, configurable synchronization
mechanism.

Signed-off-by: Julius Werner <[email protected]>
Signed-off-by: Dongjin Kim <[email protected]>
Acked-by: Olof Johansson <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
  • Loading branch information
jwerner-chromium authored and gregkh committed Jun 3, 2013
1 parent ccf92c9 commit 06a962f
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions drivers/usb/misc/usb3503.c
Original file line number Diff line number Diff line change
Expand Up @@ -105,11 +105,9 @@ static int usb3503_reset(int gpio_reset, int state)
if (gpio_is_valid(gpio_reset))
gpio_set_value(gpio_reset, state);

/* Wait RefClk when RESET_N is released, otherwise Hub will
* not transition to Hub Communication Stage.
*/
/* Wait T_HUBINIT == 4ms for hub logic to stabilize */
if (state)
msleep(100);
usleep_range(4000, 10000);

return 0;
}
Expand Down

0 comments on commit 06a962f

Please sign in to comment.