Skip to content

Commit

Permalink
[MIPS] PNX8550: Cleanup proc code.
Browse files Browse the repository at this point in the history
Here's a slightly cleaner way of creating the /proc structure for the
pnx8850.  mostly, it creates a directory with default mode 555, since the
one you're creating is mode 444, which is somewhat unusual for a directory
under /proc.

Signed-off-by: Ralf Baechle <[email protected]>
  • Loading branch information
Robert P. J. Day authored and ralfbaechle committed Jul 10, 2007
1 parent 569fb75 commit 105b1bc
Showing 1 changed file with 17 additions and 13 deletions.
30 changes: 17 additions & 13 deletions arch/mips/philips/pnx8550/common/proc.c
Original file line number Diff line number Diff line change
Expand Up @@ -78,29 +78,33 @@ static int pnx8550_proc_init( void )
{

// Create /proc/pnx8550
pnx8550_dir = create_proc_entry("pnx8550", S_IFDIR|S_IRUGO, NULL);
pnx8550_dir = proc_mkdir("pnx8550", NULL);
if (!pnx8550_dir) {
printk(KERN_ERR "Can't create pnx8550 proc dir\n");
return -1;
}

// Create /proc/pnx8550/timers
pnx8550_timers = create_proc_entry("timers", S_IFREG|S_IRUGO, pnx8550_dir );
if (pnx8550_timers){
pnx8550_timers->read_proc = pnx8550_timers_read;
}
else {
pnx8550_timers = create_proc_read_entry(
"timers",
0,
pnx8550_dir,
pnx8550_timers_read,
NULL);

if (!pnx8550_timers)
printk(KERN_ERR "Can't create pnx8550 timers proc file\n");
}

// Create /proc/pnx8550/registers
pnx8550_registers = create_proc_entry("registers", S_IFREG|S_IRUGO, pnx8550_dir );
if (pnx8550_registers){
pnx8550_registers->read_proc = pnx8550_registers_read;
}
else {
pnx8550_registers = create_proc_read_entry(
"registers",
0,
pnx8550_dir,
pnx8550_registers_read,
NULL);

if (!pnx8550_registers)
printk(KERN_ERR "Can't create pnx8550 registers proc file\n");
}

return 0;
}
Expand Down

0 comments on commit 105b1bc

Please sign in to comment.