logfs: check for the return value after calling find_or_create_page()

In get_mapping_page(), after calling find_or_create_page(), the return value should be checked. This patch has been provided: http://www.spinics.net/lists/linux-fsdevel/msg66948.html but not been applied now. Signed-off-by: Younger Liu <[email protected]> Cc: Younger Liu <[email protected]> Cc: Vyacheslav Dubeyko <[email protected]> Reviewed-by: Prasad Joshi <[email protected]> Cc: Jörn Engel <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
iegor · Jan 24, 2014 · 2252b62 · 2252b62
1 parent a3b25d9
commit 2252b62
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/fs/logfs/segment.c b/fs/logfs/segment.c
@@ -62,7 +62,8 @@ static struct page *get_mapping_page(struct super_block *sb, pgoff_t index,
 		page = read_cache_page(mapping, index, filler, sb);
 	else {
 		page = find_or_create_page(mapping, index, GFP_NOFS);
-		unlock_page(page);
+		if (page)
+			unlock_page(page);
 	}
 	return page;
 }