Skip to content

Commit

Permalink
init/main: use __init_refok to fix section mismatch
Browse files Browse the repository at this point in the history
Kill a special case in modpost by introducing the
__init_refok marker.

Signed-off-by: Sam Ravnborg <[email protected]>
  • Loading branch information
sravnborg committed May 19, 2007
1 parent 0e0d314 commit 9208030
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 15 deletions.
2 changes: 1 addition & 1 deletion init/main.c
Original file line number Diff line number Diff line change
Expand Up @@ -423,7 +423,7 @@ static void __init setup_command_line(char *command_line)
* gcc-3.4 accidentally inlines this function, so use noinline.
*/

static void noinline rest_init(void)
static void noinline __init_refok rest_init(void)
__releases(kernel_lock)
{
int pid;
Expand Down
14 changes: 0 additions & 14 deletions scripts/mod/modpost.c
Original file line number Diff line number Diff line change
Expand Up @@ -626,14 +626,6 @@ static int strrcmp(const char *s, const char *sub)
* This pattern is identified by
* refsymname = __init_begin, _sinittext, _einittext
*
* Pattern 6:
* During the early init phase we have references from .init.text to
* .text we have an intended section mismatch - do not warn about it.
* See kernel_init() in init/main.c
* tosec = .init.text
* fromsec = .text
* atsym = kernel_init
*
* Pattern 7:
* Logos used in drivers/video/logo reside in __initdata but the
* funtion that references them are EXPORT_SYMBOL() so cannot be
Expand Down Expand Up @@ -738,12 +730,6 @@ static int secref_whitelist(const char *modname, const char *tosec,
if (strcmp(refsymname, *s) == 0)
return 1;

/* Check for pattern 6 */
if ((strcmp(tosec, ".init.text") == 0) &&
(strcmp(fromsec, ".text") == 0) &&
(strcmp(refsymname, "kernel_init") == 0))
return 1;

/* Check for pattern 7 */
if ((strcmp(tosec, ".init.data") == 0) &&
(strncmp(fromsec, ".text", strlen(".text")) == 0) &&
Expand Down

0 comments on commit 9208030

Please sign in to comment.