Skip to content

Commit

Permalink
[ALSA] at73c213: remove redundant private_free routine
Browse files Browse the repository at this point in the history
snd_pcm_lib_preallocate_free_for_all() is called from snd_pcm_free() just
after calling the private_free routine.  So there should be no need to call
it in driver's private_free routine.

Signed-off-by: Atsushi Nemoto <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Takashi Iwai <[email protected]>
  • Loading branch information
atsushi-nemoto authored and tiwai committed Apr 24, 2008
1 parent 9166257 commit 9f2f0f7
Showing 1 changed file with 0 additions and 10 deletions.
10 changes: 0 additions & 10 deletions sound/spi/at73c213.c
Original file line number Diff line number Diff line change
Expand Up @@ -325,15 +325,6 @@ static struct snd_pcm_ops at73c213_playback_ops = {
.pointer = snd_at73c213_pcm_pointer,
};

static void snd_at73c213_pcm_free(struct snd_pcm *pcm)
{
struct snd_at73c213 *chip = snd_pcm_chip(pcm);
if (chip->pcm) {
snd_pcm_lib_preallocate_free_for_all(chip->pcm);
chip->pcm = NULL;
}
}

static int __devinit snd_at73c213_pcm_new(struct snd_at73c213 *chip, int device)
{
struct snd_pcm *pcm;
Expand All @@ -345,7 +336,6 @@ static int __devinit snd_at73c213_pcm_new(struct snd_at73c213 *chip, int device)
goto out;

pcm->private_data = chip;
pcm->private_free = snd_at73c213_pcm_free;
pcm->info_flags = SNDRV_PCM_INFO_BLOCK_TRANSFER;
strcpy(pcm->name, "at73c213");
chip->pcm = pcm;
Expand Down

0 comments on commit 9f2f0f7

Please sign in to comment.