Skip to content

Commit

Permalink
perf hists browser: The dso can be obtained from popup_action->ms.map…
Browse files Browse the repository at this point in the history
…->dso

So no need to have a 'dso' member in 'popup_action', remove it as no
code is using it, already.

Cc: Adrian Hunter <[email protected]>
Cc: David Ahern <[email protected]>
Cc: Jiri Olsa <[email protected]>
Cc: Namhyung Kim <[email protected]>
Cc: Wang Nan <[email protected]>
Link: http://lkml.kernel.org/n/[email protected]
Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
  • Loading branch information
acmel committed Nov 12, 2015
1 parent fae0065 commit b7f294b
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions tools/perf/ui/browsers/hists.c
Original file line number Diff line number Diff line change
@@ -1430,7 +1430,6 @@ static int switch_data_file(void)

struct popup_action {
struct thread *thread;
struct dso *dso;
struct map_symbol ms;
int socket;

@@ -1565,7 +1564,6 @@ add_dso_opt(struct hist_browser *browser, struct popup_action *act,
return 0;

act->ms.map = map;
act->dso = map->dso;
act->fn = do_zoom_dso;
return 1;
}
@@ -1827,7 +1825,6 @@ static int perf_evsel__hists_browse(struct perf_evsel *evsel, int nr_events,

while (1) {
struct thread *thread = NULL;
struct dso *dso = NULL;
struct map *map = NULL;
int choice = 0;
int socked_id = -1;
@@ -1839,8 +1836,6 @@ static int perf_evsel__hists_browse(struct perf_evsel *evsel, int nr_events,
if (browser->he_selection != NULL) {
thread = hist_browser__selected_thread(browser);
map = browser->selection->map;
if (map)
dso = map->dso;
socked_id = browser->he_selection->socket;
}
switch (key) {
@@ -1874,7 +1869,6 @@ static int perf_evsel__hists_browse(struct perf_evsel *evsel, int nr_events,
hist_browser__dump(browser);
continue;
case 'd':
actions->dso = dso;
actions->ms.map = map;
do_zoom_dso(browser, actions);
continue;

0 comments on commit b7f294b

Please sign in to comment.