Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
net/core: ensure features get disabled on new lower devs
With moving netdev_sync_lower_features() after the .ndo_set_features calls, I neglected to verify that devices added *after* a flag had been disabled on an upper device were properly added with that flag disabled as well. This currently happens, because we exit __netdev_update_features() when we see dev->features == features for the upper dev. We can retain the optimization of leaving without calling .ndo_set_features with a bit of tweaking and a goto here. Fixes: fd867d5 ("net/core: generic support for disabling netdev features down stack") CC: "David S. Miller" <[email protected]> CC: Eric Dumazet <[email protected]> CC: Jay Vosburgh <[email protected]> CC: Veaceslav Falico <[email protected]> CC: Andy Gospodarek <[email protected]> CC: Jiri Pirko <[email protected]> CC: Nikolay Aleksandrov <[email protected]> CC: Michal Kubecek <[email protected]> CC: Alexander Duyck <[email protected]> CC: [email protected] Reported-by: Nikolay Aleksandrov <[email protected]> Signed-off-by: Jarod Wilson <[email protected]> Signed-off-by: David S. Miller <[email protected]>
- Loading branch information