Skip to content

Commit

Permalink
parisc: Remove BKL from eisa_eeprom
Browse files Browse the repository at this point in the history
Remove the empty ioctl and the cycle_kernel_lock() in
eisa_eeprom_open() which got there with the big BKL push down. There
is nothing to wait for and sychronize with after the misc device has
been registered.

Remove the empty ioctl as well. The generic code handles the -ENOTTY
if no ioctl function is provided.

Signed-off-by: Thomas Gleixner <[email protected]>
LKML-Reference: <[email protected]>
Cc: Kyle McMartin <[email protected]>
  • Loading branch information
KAGA-KOKO committed Oct 14, 2009
1 parent a5ee6dc commit eb29b75
Showing 1 changed file with 0 additions and 10 deletions.
10 changes: 0 additions & 10 deletions drivers/parisc/eisa_eeprom.c
Original file line number Diff line number Diff line change
Expand Up @@ -75,17 +75,8 @@ static ssize_t eisa_eeprom_read(struct file * file,
return ret;
}

static int eisa_eeprom_ioctl(struct inode *inode, struct file *file,
unsigned int cmd,
unsigned long arg)
{
return -ENOTTY;
}

static int eisa_eeprom_open(struct inode *inode, struct file *file)
{
cycle_kernel_lock();

if (file->f_mode & FMODE_WRITE)
return -EINVAL;

Expand All @@ -104,7 +95,6 @@ static const struct file_operations eisa_eeprom_fops = {
.owner = THIS_MODULE,
.llseek = eisa_eeprom_llseek,
.read = eisa_eeprom_read,
.ioctl = eisa_eeprom_ioctl,
.open = eisa_eeprom_open,
.release = eisa_eeprom_release,
};
Expand Down

0 comments on commit eb29b75

Please sign in to comment.