Skip to content

Commit

Permalink
cache 'everyone' search result in new conversations
Browse files Browse the repository at this point in the history
fixes CNVS-12865

test plan
- as a teacher in new conversations, compose a new message
- select 'all in course' from the people picker drop down
- ensure that 'all in course' can be selected
- ensure that the message can be sent and is delivered to all
 users in the course

Change-Id: I6f2e0ad30ca2a09e52b4b5b764f3c21ecc0628f0
Reviewed-on: https://gerrit.instructure.com/34291
Tested-by: Jenkins <[email protected]>
Reviewed-by: Jon Willesen <[email protected]>
QA-Review: Steven Shepherd <[email protected]>
Product-Review: Joel Hough <[email protected]>
  • Loading branch information
JoelHough authored and codekitchen committed May 5, 2014
1 parent 0462b65 commit d653acb
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -271,9 +271,9 @@ define [
# Returns nothing.
_onSearchResultLoad: =>
@cache[@currentUrl] = @resultCollection.toJSON()
@resultCollection.each @_addToModelCache
_.extend(@permissions, @_getPermissions())
@_addEveryoneResult(@resultCollection) unless @excludeAll or !@_canSendToAll()
@resultCollection.each @_addToModelCache
shouldDrawResults = @resultCollection.length
isFinished = !@nextRequest
@_addBackResult(@resultCollection)
Expand Down

0 comments on commit d653acb

Please sign in to comment.