Separate menu item for Exec shell

Login to container's shell is very popular operation and to make it easier it will be better to make it as a separate menu item with a dedicated hot key.
igoventura · Dec 12, 2020 · 2688801 · 2688801
1 parent 4306000
commit 2688801
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 0 deletions.
diff --git a/pkg/gui/containers_panel.go b/pkg/gui/containers_panel.go
@@ -509,6 +509,21 @@ func (gui *Gui) handleContainerViewLogs(g *gocui.Gui, v *gocui.View) error {
 	return gui.Errors.ErrSubProcess
 }
 
+func (gui *Gui) handleContainersExecShell(g *gocui.Gui, v *gocui.View) error {
+	container, err := gui.getSelectedContainer()
+	if err != nil {
+		return nil
+	}
+	commandObject := gui.DockerCommand.NewCommandObject(commands.CommandObject{
+		Container: container,
+	})
+	resolvedCommand := utils.ApplyTemplate("docker exec -it {{ .Container.ID }} /bin/sh -c 'eval $(grep ^$(id -un): /etc/passwd | cut -d : -f 7-)'", commandObject)
+	// attach and return the subprocess error
+	cmd := gui.OSCommand.ExecutableFromString(resolvedCommand)
+	gui.SubProcess = cmd
+	return gui.Errors.ErrSubProcess
+}
+
 func (gui *Gui) handleContainersCustomCommand(g *gocui.Gui, v *gocui.View) error {
 	container, err := gui.getSelectedContainer()
 	if err != nil {

diff --git a/pkg/gui/keybindings.go b/pkg/gui/keybindings.go
@@ -248,6 +248,13 @@ func (gui *Gui) GetInitialKeybindings() []*Binding {
 			Handler:     gui.handleContainerViewLogs,
 			Description: gui.Tr.ViewLogs,
 		},
+		{
+			ViewName:    "containers",
+			Key:         'E',
+			Modifier:    gocui.ModNone,
+			Handler:     gui.handleContainersExecShell,
+			Description: gui.Tr.ExecShell,
+		},
 		{
 			ViewName:    "containers",
 			Key:         'c',

diff --git a/pkg/i18n/english.go b/pkg/i18n/english.go
@@ -80,6 +80,7 @@ type TranslationSet struct {
 	StopAllContainers          string
 	RemoveAllContainers        string
 	ViewRestartOptions         string
+	ExecShell                  string
 	RunCustomCommand           string
 	ViewBulkCommands           string
 
@@ -148,6 +149,7 @@ func englishSet() TranslationSet {
 		StopAllContainers:   "stop all containers",
 		RemoveAllContainers: "remove all containers (forced)",
 		ViewRestartOptions:  "view restart options",
+		ExecShell:           "exec shell",
 		RunCustomCommand:    "run predefined custom command",
 		ViewBulkCommands:    "view bulk commands",